From 6be9ee7ce496afadc70f50e3b6864fa04b0aa909 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Wed, 25 Feb 2026 08:02:09 -0600 Subject: [PATCH] mb/google/link: Use AZALIA_PIN_DESC macros for pin widgets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update the Creative CA0132 Pin Widget Verb Table from raw hex config values to AZALIA_PIN_DESC for NIDs 0x0B–0x13, and use AZALIA_PIN_CFG_NC(0) for N/C pins (0x0C–0x0F). Mapping generated by hda-decoder utility. TEST=build/boot LINK Change-Id: Ia1c9bce2bf0a71aa3a60678828cbc6bc55f7bfc1 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/91443 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/mainboard/google/link/hda_verb.c | 53 +++++++++++++++++++++++----- 1 file changed, 44 insertions(+), 9 deletions(-) diff --git a/src/mainboard/google/link/hda_verb.c b/src/mainboard/google/link/hda_verb.c index d3309cd6d7..07f88be305 100644 --- a/src/mainboard/google/link/hda_verb.c +++ b/src/mainboard/google/link/hda_verb.c @@ -72,31 +72,66 @@ const u32 cim_verb_data[] = { AZALIA_SUBVENDOR(0, 0x10280550), /* Pin Complex (NID 0x0B) Port-G Analog Unknown Speaker at Int N/A */ - AZALIA_PIN_CFG(0, 0x0b, 0x901700f0), + AZALIA_PIN_CFG(0, 0x0b, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_INTERNAL, + AZALIA_SPEAKER, + AZALIA_OTHER_ANALOG, + AZALIA_COLOR_UNKNOWN, + AZALIA_JACK_PRESENCE_DETECT, + 15, 0)), /* Pin Complex (NID 0x0C) N/C */ - AZALIA_PIN_CFG(0, 0x0c, 0x70f000f0), + AZALIA_PIN_CFG(0, 0x0c, AZALIA_PIN_CFG_NC(0)), /* Pin Complex (NID 0x0D) N/C */ - AZALIA_PIN_CFG(0, 0x0d, 0x70f000f0), + AZALIA_PIN_CFG(0, 0x0d, AZALIA_PIN_CFG_NC(0)), /* Pin Complex (NID 0x0E) N/C */ - AZALIA_PIN_CFG(0, 0x0e, 0x70f000f0), + AZALIA_PIN_CFG(0, 0x0e, AZALIA_PIN_CFG_NC(0)), /* Pin Complex (NID 0x0F) N/C */ - AZALIA_PIN_CFG(0, 0x0f, 0x70f000f0), + AZALIA_PIN_CFG(0, 0x0f, AZALIA_PIN_CFG_NC(0)), /* Pin Complex (NID 0x10) Port-D 1/8 Black HP Out at Ext Left */ - AZALIA_PIN_CFG(0, 0x10, 0x032110f0), + AZALIA_PIN_CFG(0, 0x10, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_LEFT, + AZALIA_HP_OUT, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 15, 0)), /* Pin Complex (NID 0x11) Port-B Click Mic */ - AZALIA_PIN_CFG(0, 0x11, 0x90a700f0), + AZALIA_PIN_CFG(0, 0x11, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_INTERNAL, + AZALIA_MIC_IN, + AZALIA_OTHER_ANALOG, + AZALIA_COLOR_UNKNOWN, + AZALIA_JACK_PRESENCE_DETECT, + 15, 0)), /* Pin Complex (NID 0x12) Port-C Combo Jack Mic or D-Mic */ - AZALIA_PIN_CFG(0, 0x12, 0x03a110f0), + AZALIA_PIN_CFG(0, 0x12, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_LEFT, + AZALIA_MIC_IN, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 15, 0)), /* Pin Complex (NID 0x13) What you hear */ - AZALIA_PIN_CFG(0, 0x13, 0x90d600f0), + AZALIA_PIN_CFG(0, 0x13, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_INTERNAL, + AZALIA_DIGITAL_OTHER_IN, + AZALIA_OTHER_DIGITAL, + AZALIA_COLOR_UNKNOWN, + AZALIA_JACK_PRESENCE_DETECT, + 15, 0)), /* coreboot specific header */ 0x80862806, // Codec Vendor / Device ID: Intel CougarPoint HDMI