diff --git a/src/mainboard/google/veyron_brain/boardid.c b/src/mainboard/google/veyron_brain/boardid.c index 65509d25ab..513754f048 100644 --- a/src/mainboard/google/veyron_brain/boardid.c +++ b/src/mainboard/google/veyron_brain/boardid.c @@ -42,7 +42,7 @@ uint32_t ram_code(void) static gpio_t pins[] = {[3] = GPIO(8, A, 3), [2] = GPIO(8, A, 2), [1] = GPIO(8, A, 1), [0] = GPIO(8, A, 0)}; /* GPIO8_A0 is LSB */ - code = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); + code = gpio_base2_value(pins, ARRAY_SIZE(pins)); printk(BIOS_SPEW, "RAM Config: %u.\n", code); return code; diff --git a/src/mainboard/google/veyron_brain/sdram_configs.c b/src/mainboard/google/veyron_brain/sdram_configs.c index f8760a8fb0..1de6dc6278 100644 --- a/src/mainboard/google/veyron_brain/sdram_configs.c +++ b/src/mainboard/google/veyron_brain/sdram_configs.c @@ -41,16 +41,9 @@ static struct rk3288_sdram_params sdram_configs[] = { #include "sdram_inf/sdram-ddr3-hynix-2GB.inc" /* ram_code = 1101 */ #include "sdram_inf/sdram-ddr3-samsung-4GB.inc" /* ram_code = 1110 */ #include "sdram_inf/sdram-ddr3-hynix-4GB.inc" /* ram_code = 1111 */ -#include "sdram_inf/sdram-ddr3-samsung-2GB.inc" /* ram_code = 000Z */ -#include "sdram_inf/sdram-lpddr3-micron-2GB-D2.inc" /* ram_code = 001Z */ -#include "sdram_inf/sdram-lpddr3-hynix-2GB-BK.inc" /* ram_code = 00Z0 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00Z1 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00ZZ */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 010Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 011Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 01Z0 */ +/* Brain, Jaq, Jerry and Mighty cannot support tri-state, see b/36279493! */ }; -_Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); +_Static_assert(ARRAY_SIZE(sdram_configs) == 16, "Must have 16 sdram_configs!"); const struct rk3288_sdram_params *get_sdram_config() { diff --git a/src/mainboard/google/veyron_jaq/boardid.c b/src/mainboard/google/veyron_jaq/boardid.c index 65509d25ab..513754f048 100644 --- a/src/mainboard/google/veyron_jaq/boardid.c +++ b/src/mainboard/google/veyron_jaq/boardid.c @@ -42,7 +42,7 @@ uint32_t ram_code(void) static gpio_t pins[] = {[3] = GPIO(8, A, 3), [2] = GPIO(8, A, 2), [1] = GPIO(8, A, 1), [0] = GPIO(8, A, 0)}; /* GPIO8_A0 is LSB */ - code = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); + code = gpio_base2_value(pins, ARRAY_SIZE(pins)); printk(BIOS_SPEW, "RAM Config: %u.\n", code); return code; diff --git a/src/mainboard/google/veyron_jaq/sdram_configs.c b/src/mainboard/google/veyron_jaq/sdram_configs.c index f8760a8fb0..1de6dc6278 100644 --- a/src/mainboard/google/veyron_jaq/sdram_configs.c +++ b/src/mainboard/google/veyron_jaq/sdram_configs.c @@ -41,16 +41,9 @@ static struct rk3288_sdram_params sdram_configs[] = { #include "sdram_inf/sdram-ddr3-hynix-2GB.inc" /* ram_code = 1101 */ #include "sdram_inf/sdram-ddr3-samsung-4GB.inc" /* ram_code = 1110 */ #include "sdram_inf/sdram-ddr3-hynix-4GB.inc" /* ram_code = 1111 */ -#include "sdram_inf/sdram-ddr3-samsung-2GB.inc" /* ram_code = 000Z */ -#include "sdram_inf/sdram-lpddr3-micron-2GB-D2.inc" /* ram_code = 001Z */ -#include "sdram_inf/sdram-lpddr3-hynix-2GB-BK.inc" /* ram_code = 00Z0 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00Z1 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00ZZ */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 010Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 011Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 01Z0 */ +/* Brain, Jaq, Jerry and Mighty cannot support tri-state, see b/36279493! */ }; -_Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); +_Static_assert(ARRAY_SIZE(sdram_configs) == 16, "Must have 16 sdram_configs!"); const struct rk3288_sdram_params *get_sdram_config() { diff --git a/src/mainboard/google/veyron_jerry/boardid.c b/src/mainboard/google/veyron_jerry/boardid.c index 65509d25ab..513754f048 100644 --- a/src/mainboard/google/veyron_jerry/boardid.c +++ b/src/mainboard/google/veyron_jerry/boardid.c @@ -42,7 +42,7 @@ uint32_t ram_code(void) static gpio_t pins[] = {[3] = GPIO(8, A, 3), [2] = GPIO(8, A, 2), [1] = GPIO(8, A, 1), [0] = GPIO(8, A, 0)}; /* GPIO8_A0 is LSB */ - code = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); + code = gpio_base2_value(pins, ARRAY_SIZE(pins)); printk(BIOS_SPEW, "RAM Config: %u.\n", code); return code; diff --git a/src/mainboard/google/veyron_jerry/sdram_configs.c b/src/mainboard/google/veyron_jerry/sdram_configs.c index f8760a8fb0..1de6dc6278 100644 --- a/src/mainboard/google/veyron_jerry/sdram_configs.c +++ b/src/mainboard/google/veyron_jerry/sdram_configs.c @@ -41,16 +41,9 @@ static struct rk3288_sdram_params sdram_configs[] = { #include "sdram_inf/sdram-ddr3-hynix-2GB.inc" /* ram_code = 1101 */ #include "sdram_inf/sdram-ddr3-samsung-4GB.inc" /* ram_code = 1110 */ #include "sdram_inf/sdram-ddr3-hynix-4GB.inc" /* ram_code = 1111 */ -#include "sdram_inf/sdram-ddr3-samsung-2GB.inc" /* ram_code = 000Z */ -#include "sdram_inf/sdram-lpddr3-micron-2GB-D2.inc" /* ram_code = 001Z */ -#include "sdram_inf/sdram-lpddr3-hynix-2GB-BK.inc" /* ram_code = 00Z0 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00Z1 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00ZZ */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 010Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 011Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 01Z0 */ +/* Brain, Jaq, Jerry and Mighty cannot support tri-state, see b/36279493! */ }; -_Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); +_Static_assert(ARRAY_SIZE(sdram_configs) == 16, "Must have 16 sdram_configs!"); const struct rk3288_sdram_params *get_sdram_config() { diff --git a/src/mainboard/google/veyron_mighty/boardid.c b/src/mainboard/google/veyron_mighty/boardid.c index 65509d25ab..513754f048 100644 --- a/src/mainboard/google/veyron_mighty/boardid.c +++ b/src/mainboard/google/veyron_mighty/boardid.c @@ -42,7 +42,7 @@ uint32_t ram_code(void) static gpio_t pins[] = {[3] = GPIO(8, A, 3), [2] = GPIO(8, A, 2), [1] = GPIO(8, A, 1), [0] = GPIO(8, A, 0)}; /* GPIO8_A0 is LSB */ - code = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); + code = gpio_base2_value(pins, ARRAY_SIZE(pins)); printk(BIOS_SPEW, "RAM Config: %u.\n", code); return code; diff --git a/src/mainboard/google/veyron_mighty/sdram_configs.c b/src/mainboard/google/veyron_mighty/sdram_configs.c index f8760a8fb0..1de6dc6278 100644 --- a/src/mainboard/google/veyron_mighty/sdram_configs.c +++ b/src/mainboard/google/veyron_mighty/sdram_configs.c @@ -41,16 +41,9 @@ static struct rk3288_sdram_params sdram_configs[] = { #include "sdram_inf/sdram-ddr3-hynix-2GB.inc" /* ram_code = 1101 */ #include "sdram_inf/sdram-ddr3-samsung-4GB.inc" /* ram_code = 1110 */ #include "sdram_inf/sdram-ddr3-hynix-4GB.inc" /* ram_code = 1111 */ -#include "sdram_inf/sdram-ddr3-samsung-2GB.inc" /* ram_code = 000Z */ -#include "sdram_inf/sdram-lpddr3-micron-2GB-D2.inc" /* ram_code = 001Z */ -#include "sdram_inf/sdram-lpddr3-hynix-2GB-BK.inc" /* ram_code = 00Z0 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00Z1 */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 00ZZ */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 010Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 011Z */ -#include "sdram_inf/sdram-unused.inc" /* ram_code = 01Z0 */ +/* Brain, Jaq, Jerry and Mighty cannot support tri-state, see b/36279493! */ }; -_Static_assert(ARRAY_SIZE(sdram_configs) == 24, "Must have 24 sdram_configs!"); +_Static_assert(ARRAY_SIZE(sdram_configs) == 16, "Must have 16 sdram_configs!"); const struct rk3288_sdram_params *get_sdram_config() {