From 6aeebc4b4b6055b3638b19a9cd933c005757f748 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 4 Jun 2025 11:13:18 +0100 Subject: [PATCH] mb/starlabs/byte_adl: Reconfigure PCH Strap GPIOs Configure all strap GPIOs as outputs, rather than some being not connected. This doesn't change anything, but is more explicit. Set these all to sample on RSMRST. Change-Id: I693cfecdb73a20b76fa040500eed5d904b857710 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87937 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- .../starlabs/byte_adl/variants/mk_ii/gpio.c | 51 ++++++------------- 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 5c692691d3..fc963f7645 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -75,16 +75,26 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + /* Config Straps [ Low / High ] */ + PAD_CFG_GPO(GPP_B14, 0, RSMRST), /* Top Swap [ Disabled / Enabled ] */ + PAD_CFG_GPO(GPP_B18, 0, RSMRST), /* Reboot Support [ Enabled / Disabled ] */ + PAD_CFG_GPO(GPP_C2, 1, RSMRST), /* TLS Confidentiality [ Disabled / Enabled ] */ + PAD_CFG_GPO(GPP_C5, 0, RSMRST), /* eSPI [ Enabled / Disabled ] */ + PAD_CFG_GPO(GPP_E6, 0, RSMRST), /* JTAG ODT [ Disabled / Enabled ] */ + PAD_CFG_GPO(GPP_H1, 0, RSMRST), /* BFX Strap 2 Bit 3 [ Disabled / Enabled ] */ + PAD_CFG_GPO(GPP_E19, 0, RSMRST), /* TBT LSX #0 [ 1.8V / 3.3V ] */ + PAD_CFG_GPO(GPP_E21, 0, RSMRST), /* TBT LSX #1 [ 1.8V / 3.3V ] */ + PAD_CFG_GPO(GPP_D10, 0, RSMRST), /* TBT LSX #2 [ 1.8V / 3.3V ] */ + PAD_CFG_GPO(GPP_D12, 0, RSMRST), /* TBT LSX #3 [ 1.8V / 3.3V ] */ + PAD_CFG_GPO(GPP_F7, 0, RSMRST), /* MCRO LDO [ Disabled / Bypass ] */ + PAD_CFG_GPO(GPD7, 0, RSMRST), /* RTC Clock Delay [ Disabled / 95ms ] */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), - /* GPD7: Power Adapter Disable */ - PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), - /* GPD10: Sleep S5 */ - PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), @@ -138,20 +148,12 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), - /* B14: Top Swap Override Weak Internal PD 20K - High: Enabled - Low: Disabled */ - PAD_CFG_GPO(GPP_B14, 0, PLTRST), /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), /* B16: Not Connected */ PAD_NC(GPP_B16, NONE), /* B17: Not Connected */ PAD_NC(GPP_B17, NONE), - /* B18: Reboot Support Weak Internal PD 20K - High: Disabled - Low: Enabled */ - PAD_NC(GPP_B18, NONE), /* B19: Not Connected */ PAD_NC(GPP_B19, NONE), /* B20: Not Connected */ @@ -167,18 +169,10 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C2: TLS Confidentiality Weak Internal PD 20K - Low: Disabled - High: Enabled */ - PAD_CFG_GPO(GPP_C2, 1, PLTRST), /* C3: SML 0 Clock */ PAD_CFG_NF(GPP_C3, NONE, DEEP, NF1), /* C4: SML 0 Data */ PAD_CFG_NF(GPP_C4, NONE, DEEP, NF1), - /* C5: Boot Strap Weak Internal PD 20K - Low: ESPI - High: Disabled */ - PAD_CFG_GPO(GPP_C5, 0, DEEP), /* C6: SML 1 Clock */ PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), /* C7: SML 1 Data */ @@ -238,8 +232,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_D10, NONE), /* D11: GSPI 2 MISO FPS */ PAD_NC(GPP_D11, NONE), - /* D12: GSPI 2 MOSI FPS */ - PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), /* D14: Test Point 10 */ @@ -263,10 +255,7 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ PAD_NC(GPP_E5, NONE), - /* E6: JTAG ODT No internal PD - Low: Disabled - High: Enabled */ - PAD_CFG_GPO(GPP_E6, 0, DEEP), + /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E9: USB OverCurrent 0 */ @@ -287,12 +276,8 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E17, NONE), /* E18: Not Connected */ PAD_NC(GPP_E18, NONE), - /* E19: Thunderbolt LSX RXD */ - PAD_NC(GPP_E19, NONE), /* E20: Not Connected */ PAD_NC(GPP_E20, NONE), - /* E21: Not Connected */ - PAD_NC(GPP_E21, NONE), /* E22: Not Connected */ PAD_NC(GPP_E22, NONE), /* E23: Not Connected */ @@ -300,10 +285,6 @@ const struct pad_config gpio_table[] = { /* F6: CNV PA Blanking */ PAD_NC(GPP_F6, NONE), - /* F7: TBT LSX VCCIO Weak Internal PD 20K - Low: 1.8V - High: 3.3V */ - PAD_CFG_GPO(GPP_F7, 0, DEEP), /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: */ @@ -337,8 +318,6 @@ const struct pad_config gpio_table[] = { /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */