From 69e8fedf6eeba71a7ddaee88a57864e6dbf1a8c1 Mon Sep 17 00:00:00 2001
From: Sean Rhodes <sean@starlabs.systems>
Date: Fri, 11 Oct 2024 11:32:35 +0100
Subject: [PATCH] mb/starlabs/*: Add ACPI for default brightness levels

Include `default_brightness_levels.asl` in the DSDT, and
add the default brightness levels entry to the igpu.

This allows brightness controls to be used on Windows.

Change-Id: Ide0bec650e010fd294b852f640b275df6f939393
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84726
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
---
 src/mainboard/starlabs/lite/dsdt.asl                          | 2 ++
 src/mainboard/starlabs/lite/variants/glk/devicetree.cb        | 4 +++-
 src/mainboard/starlabs/lite/variants/glkr/devicetree.cb       | 4 +++-
 src/mainboard/starlabs/starbook/dsdt.asl                      | 1 +
 src/mainboard/starlabs/starbook/variants/adl/devicetree.cb    | 1 +
 src/mainboard/starlabs/starbook/variants/cml/devicetree.cb    | 4 +++-
 src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb    | 4 +++-
 src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb    | 1 +
 src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb    | 4 +++-
 src/mainboard/starlabs/starfighter/dsdt.asl                   | 1 +
 src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb | 1 +
 11 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/starlabs/lite/dsdt.asl b/src/mainboard/starlabs/lite/dsdt.asl
index 13a1eb626c..c47ebb016f 100644
--- a/src/mainboard/starlabs/lite/dsdt.asl
+++ b/src/mainboard/starlabs/lite/dsdt.asl
@@ -22,6 +22,8 @@ DefinitionBlock(
 		#include <soc/intel/apollolake/acpi/southbridge.asl>
 		#include <soc/intel/apollolake/acpi/pch_hda.asl>
 
+		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
+
 		/* PS/2 Keyboard */
 		#include <drivers/pc80/pc/ps2_controller.asl>
 	}
diff --git a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb
index d88eccd720..b93d56683a 100644
--- a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb
+++ b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb
@@ -55,7 +55,9 @@ chip soc/intel/apollolake
 	register "slp_s3_assertion_width_usecs"	= "28000"
 
 	device domain 0 on
-		device ref igd		on  end
+		device ref igd		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
+		end
 		device ref cnvi		on
 			chip drivers/wifi/generic
 				register "wake" = "GPE0A_CNVI_PME_STS"
diff --git a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb
index adb20c050f..65ac609aee 100644
--- a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb
+++ b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb
@@ -55,7 +55,9 @@ chip soc/intel/apollolake
 	register "slp_s3_assertion_width_usecs"	= "28000"
 
 	device domain 0 on
-		device ref igd		on  end
+		device ref igd		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
+		end
 		device ref cnvi		on
 			chip drivers/wifi/generic
 				register "wake" = "GPE0A_CNVI_PME_STS"
diff --git a/src/mainboard/starlabs/starbook/dsdt.asl b/src/mainboard/starlabs/starbook/dsdt.asl
index be817e306c..3b95098b4e 100644
--- a/src/mainboard/starlabs/starbook/dsdt.asl
+++ b/src/mainboard/starlabs/starbook/dsdt.asl
@@ -35,6 +35,7 @@ DefinitionBlock(
 		#include <soc/intel/alderlake/acpi/southbridge.asl>
 		#include <soc/intel/alderlake/acpi/tcss.asl>
 #endif
+		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 
 		#include <soc/intel/common/block/acpi/acpi/gna.asl>
 
diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
index 6fc820fe60..a17b7ece17 100644
--- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb
@@ -21,6 +21,7 @@ chip soc/intel/alderlake
 	# Device Tree
 	device domain 0 on
 		device ref igpu		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
 			register "ddi_portA_config"		= "1"
 			register "ddi_ports_config" = "{
 				[DDI_PORT_A]			= DDI_ENABLE_HPD,
diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
index 1c4b94c529..db646e3e6a 100644
--- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
@@ -36,7 +36,9 @@ chip soc/intel/cannonlake
 
 # Actual device tree.
 	device domain 0 on
-		device ref igpu on  end
+		device ref igpu on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
+		end
 		device ref xhci on
 			# Motherboard USB 3.0 Type-C
 			register "usb2_ports[0]"		= "USB2_PORT_TYPE_C(OC_SKIP)"
diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
index 0480902769..21c475e628 100644
--- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb
@@ -33,7 +33,9 @@ chip soc/intel/skylake
 
 # Actual device tree.
 	device domain 0 on
-		device ref igpu		on  end
+		device ref igpu		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
+		end
 		device ref south_xhci	on
 			# Motherboard USB Type C
 			register "usb2_ports[0]"		= "USB2_PORT_TYPE_C(OC_SKIP)"
diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
index 389bb5aa39..a411446638 100644
--- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb
@@ -23,6 +23,7 @@ chip soc/intel/alderlake
 	# Device Tree
 	device domain 0 on
 		device ref igpu		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
 			register "ddi_portA_config"		= "1"
 			register "ddi_ports_config" = "{
 				[DDI_PORT_A]			= DDI_ENABLE_HPD,
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
index 3791a9d620..eb381a4ac2 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb
@@ -49,7 +49,9 @@ chip soc/intel/tigerlake
 
 # Actual device tree.
 	device domain 0 on
-		device ref igpu		on  end
+		device ref igpu		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
+		end
 		device ref tbt_pcie_rp0	on  end
 		device ref gna		on  end
 		device ref crashlog	on  end
diff --git a/src/mainboard/starlabs/starfighter/dsdt.asl b/src/mainboard/starlabs/starfighter/dsdt.asl
index 3a12299374..b7783eae63 100644
--- a/src/mainboard/starlabs/starfighter/dsdt.asl
+++ b/src/mainboard/starlabs/starfighter/dsdt.asl
@@ -20,6 +20,7 @@ DefinitionBlock(
 		#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
 		#include <soc/intel/alderlake/acpi/southbridge.asl>
 		#include <soc/intel/alderlake/acpi/tcss.asl>
+
 		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 
 		#include <soc/intel/common/block/acpi/acpi/gna.asl>
diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
index 96c3295dbf..f6551bf221 100644
--- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
+++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb
@@ -29,6 +29,7 @@ chip soc/intel/alderlake
 
 	device domain 0 on
 		device ref igpu		on
+			register "gfx"				= "GMA_DEFAULT_PANEL(0)"
 			register "ddi_portA_config"		= "1"
 			register "ddi_ports_config" = "{
 				[DDI_PORT_A]			= DDI_ENABLE_HPD,