erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ec/starlabs/merlin: Optimise Kconfig defaults

Browse source 
The featureset of Merlin is common, so adjust the Kconfig options
to avoid having the boards select all of them.

This is not a functional change.

Change-Id: Ie8d7afed750055274cdfde3f2f4f9b70fa47a8b1
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89910
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2025-11-04 20:54:26 +00:00
commit 696344ac01
5 changed files with 40 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

81
src/ec/starlabs/merlin/Kconfig
View file

@ -8,6 +8,7 @@ config EC_STARLABS_NUVOTON
config EC_STARLABS_ITE
bool
default y if EC_STARLABS_MERLIN
select EC_ACPI
help
Interface to ITE embedded controller principally in Star Labs notebooks.
@ -30,6 +31,11 @@ config EC_STARLABS_ITE_BIN_PATH
string "Star Labs EC binary file path"
depends on EC_STARLABS_ADD_ITE_BIN
config EC_STARLABS_FAN
bool
help
Select if the mainboard has a fan.
config EC_STARLABS_KBL_LEVELS
bool
default n
@ -37,46 +43,6 @@ config EC_STARLABS_KBL_LEVELS
help
Select if the mainboard supports multiple levels of brightness for the keyboard.
config EC_STARLABS_FAN
bool
default n
depends on EC_STARLABS_ITE
help
Select if the mainboard has a fan.
config EC_STARLABS_MAX_CHARGE
bool
default n
depends on EC_STARLABS_ITE
help
Select if the mainboard supports limiting the maximum charge of the battery.
config EC_STARLABS_CHARGING_SPEED
bool "Enable setting the charging speed"
depends on EC_STARLABS_MERLIN
help
Select if the mainboard supports configuring the charging speed.
config EC_STARLABS_LID_SWITCH
bool "Enable disabling the lid switch"
depends on EC_STARLABS_ITE
help
Select if the mainboard supports disabling the lid switch
config EC_STARLABS_POWER_LED
bool "Enable lowering the brightess of the Power LED"
depends on EC_STARLABS_ITE
help
Select the in the mainboard supports reducing the LED brightness
config EC_STARLABS_MERLIN
bool "Use open-source Merlin EC Firmware"
default n
depends on EC_STARLABS_ITE
help
Use open source embedded controller firmware. Both firmwares have the
same features but differ in licensing and compilers.
config EC_VARIANT_DIR
string
default "merlin" if EC_STARLABS_MERLIN
@ -96,3 +62,38 @@ config EC_STARLABS_BATTERY_TYPE
config EC_STARLABS_BATTERY_OEM
string
default "Unknown"
config EC_STARLABS_MERLIN
bool "Use open-source Merlin EC Firmware"
default n
help
Use open source embedded controller firmware. Both firmwares have the
same features but differ in licensing and compilers.
if EC_STARLABS_MERLIN
config EC_STARLABS_MAX_CHARGE
bool
default y
help
Select if the mainboard supports limiting the maximum charge of the battery.
config EC_STARLABS_CHARGING_SPEED
bool "Enable setting the charging speed"
default y
help
Select if the mainboard supports configuring the charging speed.
config EC_STARLABS_LID_SWITCH
bool "Enable disabling the lid switch"
default y
help
Select if the mainboard supports disabling the lid switch
config EC_STARLABS_POWER_LED
bool "Enable lowering the brightess of the Power LED"
default y
help
Select the in the mainboard supports reducing the LED brightness
endif