From 663dbd462a82324356d59b5b164708ebe14d72da Mon Sep 17 00:00:00 2001 From: Nicolas Kochlowski Date: Fri, 20 Dec 2024 13:54:58 -0300 Subject: [PATCH] soc/amd/phoenix: Remove outdated TODO comments Delete the "TODO: Update for Phoenix" comment from files that have already been updated in the previous chained patches (CB:85631, CB:85632, CB:85633). Change-Id: I137dbba5094ae8cbf842b45d6137c5b0528e5413 Signed-off-by: Nicolas Kochlowski Reviewed-on: https://review.coreboot.org/c/coreboot/+/85719 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Ana Carolina Cabral --- src/mainboard/amd/birman/devicetree_phoenix_opensil.cb | 2 -- src/soc/amd/phoenix/Kconfig | 1 - src/soc/amd/phoenix/Makefile.mk | 1 - src/soc/amd/phoenix/acpi.c | 1 - src/soc/amd/phoenix/chip.h | 2 -- 5 files changed, 7 deletions(-) diff --git a/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb b/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb index 9916931545..75b50a199d 100644 --- a/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb +++ b/src/mainboard/amd/birman/devicetree_phoenix_opensil.cb @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -# TODO: Update for birman - chip soc/amd/phoenix register "common_config.espi_config" = "{ .std_io_decode_bitmap = ESPI_DECODE_IO_0x80_EN | ESPI_DECODE_IO_0X2E_0X2F_EN | ESPI_DECODE_IO_0X60_0X64_EN, diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig index 995b1cc535..ac227b9f6f 100644 --- a/src/soc/amd/phoenix/Kconfig +++ b/src/soc/amd/phoenix/Kconfig @@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only # TODO: Evaluate what can be moved to a common directory -# TODO: Update for Phoenix config SOC_AMD_PHOENIX_BASE bool diff --git a/src/soc/amd/phoenix/Makefile.mk b/src/soc/amd/phoenix/Makefile.mk index 878ebe7bb7..68cc935f75 100644 --- a/src/soc/amd/phoenix/Makefile.mk +++ b/src/soc/amd/phoenix/Makefile.mk @@ -1,7 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # TODO: Move as much as possible to common -# TODO: Update for Phoenix ifeq ($(CONFIG_SOC_AMD_PHOENIX_BASE),y) diff --git a/src/soc/amd/phoenix/acpi.c b/src/soc/amd/phoenix/acpi.c index 1475b6166a..0f0ec26dae 100644 --- a/src/soc/amd/phoenix/acpi.c +++ b/src/soc/amd/phoenix/acpi.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Phoenix */ /* TODO: See what can be made common */ /* ACPI - create the Fixed ACPI Description Tables (FADT) */ diff --git a/src/soc/amd/phoenix/chip.h b/src/soc/amd/phoenix/chip.h index eabd44518e..fb0ef0f78a 100644 --- a/src/soc/amd/phoenix/chip.h +++ b/src/soc/amd/phoenix/chip.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Phoenix */ - #ifndef PHOENIX_CHIP_H #define PHOENIX_CHIP_H