erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/samsung/lumpy: Correct number of jacks in hda_verb.c

Browse source 
The verb data was not aligned to a multiple of 4, therefore an entry was
repeated as padding. This has not been tested.

This was found due to the `_Static_assert()` from CB:84360 failing.

Change-Id: I3a40e6229419ee7d1a238916ee6d49cf9314f6ab
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84395
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nicholas Sudsgaard 2024-09-17 02:17:51 +00:00 • committed by Felix Held
commit 6638b40691
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/mainboard/samsung/lumpy/hda_verb.c
View file

@ -6,12 +6,15 @@ const u32 cim_verb_data[] = {
/* coreboot specific header */
0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210
0x152D0924, // Subsystem ID
0x00000007, // Number of jacks
0x00000008, // Number of jacks
/* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x152D0924 */
AZALIA_SUBVENDOR(0, 0x152D0924),
0x00170500,
0x00170500, /* Padding */
0x00170500, /* Padding */
0x00170500, /* Padding */
/* Pin Widget Verb Table */