erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

AGESA,binaryPI: Move PORT80 selection to C bootblock

Browse source 
Because the function is implemented in C, post_code() calls
from cache_as_ram.S and other early assembly entry files may
not currently work for cold boots. Assembly implementation
needs to follow one day.

This effectively removes PORT80 routing from boards with
ROMCC_BOOTBLOCK.

Change-Id: I71aa94b33bd6f65e243724810472a440e98e0750
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37451
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
This commit is contained in:
Kyösti Mälkki 2019-12-03 12:36:09 +02:00
commit 657d68bddc
40 changed files with 32 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/console/Kconfig
View file

@ -417,6 +417,7 @@ config POST_DEVICE
choice
prompt "Device to send POST codes to"
depends on POST_DEVICE
default POST_DEVICE_LPC if DEFAULT_POST_ON_LPC
default POST_DEVICE_NONE
config POST_DEVICE_NONE
@ -429,6 +430,10 @@ config POST_DEVICE_PCI_PCIE
depends on PCI
endchoice
config DEFAULT_POST_ON_LPC
bool
default n
config POST_IO
bool "Send POST codes to an IO port"
depends on PC80_SYSTEM && !NO_POST