From 64a79d23e8e0c2126bf035e5e7804dcd72e1a629 Mon Sep 17 00:00:00 2001 From: Luca Lai Date: Wed, 25 Jun 2025 09:47:47 +0800 Subject: [PATCH] mb/trulo/var/pujjoquince: Add SD card function 1. This change is based on the fact that the code for the pujjolo and pujjoquince projects is shared. 2. Add SD card function and use proto board to verify the functionality. Schematic version: 500E_S3A0_TWL_MB_FVT_20250527 BUG=b:395763555 BRANCH=none TEST=Boot to OS and verify the mmcblk0 shown which use lsblk command, and check if sd card could store file in desktop. Change-Id: Ib7f854d9c902ba3f257d154ae6b95ea443fa78f5 Signed-off-by: Luca Lai Reviewed-on: https://review.coreboot.org/c/coreboot/+/88184 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/variants/pujjolo/gpio.c | 10 ++++++---- .../google/brya/variants/pujjolo/overridetree.cb | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/brya/variants/pujjolo/gpio.c b/src/mainboard/google/brya/variants/pujjolo/gpio.c index 96a0ef48f5..a3856d4a1a 100644 --- a/src/mainboard/google/brya/variants/pujjolo/gpio.c +++ b/src/mainboard/google/brya/variants/pujjolo/gpio.c @@ -274,10 +274,6 @@ static const struct pad_config override_gpio_table[] = { PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* H11 : UART0_TXD ==> UART_SOC_TX_DBG_RX */ PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), - /* H12 : GPP_H12 ==> NC */ - PAD_NC_LOCK(GPP_H12, NONE, LOCK_CONFIG), - /* H13 : GPP_H13 ==> NC */ - PAD_NC_LOCK(GPP_H13, NONE, LOCK_CONFIG), /* H14 : Not available */ PAD_NC(GPP_H14, NONE), /* H15 : DDPB_CTRLCLK ==> HDMI_DDC_SCL */ @@ -455,6 +451,10 @@ static const struct pad_config early_gpio_table[] = { PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* H11 : UART0_TXD ==> UART_SOC_TX_DBG_RX */ PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), + /* H12 : UART0_RTS# ==> SD_PERST_L */ + PAD_CFG_GPO(GPP_H12, 0, DEEP), + /* H13 : UART0_CTS# ==> EN_PP3300_SD_X */ + PAD_CFG_GPO(GPP_H13, 1, DEEP), }; /* Pad configuration in romstage for Sundance */ @@ -477,6 +477,8 @@ static const struct pad_config romstage_gpio_table[] = { PAD_CFG_GPO(GPP_E7, 0, DEEP), /* D2 : ISH_GP2 ==> EN_FP_PWR */ PAD_CFG_GPO(GPP_D2, 0, DEEP), + /* H12 : UART0_RTS# ==> SD_PERST_L */ + PAD_CFG_GPO(GPP_H12, 1, DEEP), }; const struct pad_config *variant_gpio_override_table(size_t *num) diff --git a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb index 71ac951e6d..1ffcf7aadc 100644 --- a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb @@ -8,7 +8,7 @@ fw_config option WIFI_SAR_TABLE_AX211 0 option WIFI_SAR_TABLE_AX203 1 end - field SD_CARD 22 + field SD_CARD 25 option SD_ABSENT 0 option SD_PRESENT 1 end