erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/amb/birman*/gpio: remove configuration for VDD_MEM_VID[0,1]

Browse source 
Fix VDD_MEM_VID[0,1] pin assignments that was causing boot issues.

Change-Id: Ie5634575aff6dad210928c9c9af808e245322b99
Signed-off-by: Ana Carolina Cabral <ana.cabral@amd.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85498
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Ana Carolina Cabral 2024-12-04 17:46:16 -03:00 • committed by Felix Held
commit 61a00269a2
2 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/mainboard/amd/birman/gpio.c
View file

@ -29,8 +29,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
PAD_SCI(GPIO_8, PULL_UP, EDGE_LOW),
/* SD_CARD_PRSNT_L */
PAD_GPI(GPIO_9, PULL_UP), /* Unclear if this needs to be SCI */
/* VDD_MEM_VID0 */
PAD_GPO(GPIO_10, HIGH),
/* GPIO_10: VDD_MEM_VID0 - Controlled by firmware outside of coreboot (ABL) */
/* HP_MIC_DET_L */
PAD_GPI(GPIO_11, PULL_UP),
/* ALIGN_FLAG_MU_L */
@ -76,8 +75,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
/* USB2_HDR_P0/1_SMI */
PAD_SCI(GPIO_40, PULL_UP, EDGE_LOW),
/* GPIO_41: Not available */
/* VDD_MEM_VID1 */
PAD_GPO(GPIO_42, HIGH),
/* GPIO_42: VDD_MEM_VID1 - Controlled by firmware outside of coreboot (ABL) */
/* GPIO_43 - GPIO_66: Not available */
/* SPI_ROM_REQ */
PAD_NF(GPIO_67, SPI_ROM_REQ, PULL_NONE),

6
src/mainboard/amd/birman_plus/gpio.c
View file

@ -29,8 +29,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
PAD_SCI(GPIO_8, PULL_UP, EDGE_LOW),
/* SD_CARD_PRSNT_L */
PAD_GPI(GPIO_9, PULL_UP), /* Unclear if this needs to be SCI */
/* VDD_MEM_VID0 */
PAD_GPO(GPIO_10, HIGH),
/* GPIO_10: VDD_MEM_VID0 - Controlled by firmware outside of coreboot (ABL) */
/* HP_MIC_DET_L */
PAD_GPI(GPIO_11, PULL_UP),
/* ALIGN_FLAG_MU_L */
@ -76,8 +75,7 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
/* USB2_HDR_P0/1_SMI */
PAD_SCI(GPIO_40, PULL_UP, EDGE_LOW),
/* GPIO_41: Not available */
/* VDD_MEM_VID1 */
PAD_GPO(GPIO_42, HIGH),
/* GPIO_42: VDD_MEM_VID1 - Controlled by firmware outside of coreboot (ABL) */
/* GPIO_43 - GPIO_66: Not available */
/* SPI_ROM_REQ */
PAD_NF(GPIO_67, SPI_ROM_REQ, PULL_NONE),