From 619bfe4cf9b93847e38d03d7076beb78fbfa1d1d Mon Sep 17 00:00:00 2001 From: David Hendricks Date: Fri, 16 Aug 2013 12:21:30 -0700 Subject: [PATCH] armv7: clean but do not invalidate caches between stages This cleans the caches without invalidating them between stages. The dcache content should still be valid when the next stage begins, so we should see a small performance gain. (thanks to gabeblack for pointing this out) Signed-off-by: David Hendricks BUG=none BRANCH=none TEST=built and booted on pit Change-Id: Ie18d163f3a78e2786e9fbc7479c8bd896b8ac3aa Reviewed-on: https://gerrit.chromium.org/gerrit/66119 Commit-Queue: David Hendricks Tested-by: David Hendricks Reviewed-by: Ronald G. Minnich --- src/arch/armv7/stages.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/armv7/stages.c b/src/arch/armv7/stages.c index 0d2072de50..38d1b1928a 100644 --- a/src/arch/armv7/stages.c +++ b/src/arch/armv7/stages.c @@ -52,7 +52,7 @@ void stage_exit(void *addr) /* make sure any code we installed is written to memory. Not all ARM have * unified caches. */ - dcache_clean_invalidate_all(); + dcache_clean_all(); /* Because most stages copy code to memory, it's a safe and hygienic thing * to flush the icache here. */