erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: drivers/intel/gma: Use scaling to simplify fb config

Browse source 
Utilize libgfxinit's support for scaling to simplify the framebuffer
configuration. In case of multiple displays of different resolutions,
we had configured one framebuffer big enough for their union, each
display only showing its respective upper left window. Instead, we use
the smallest resolution now and show the whole image on all displays.

BUG=None
BRANCH=None
TEST=None

Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/17492
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Tested-by: build bot (Jenkins)

Change-Id: I70a9d92f88ef891703829945264f94ac7eff09b0
Reviewed-on: https://chromium-review.googlesource.com/422564
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Nico Huber 2016-11-08 12:29:50 +01:00 • committed by chrome-bot
commit 5dcfa26c6b
1 changed files with 11 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/drivers/intel/gma/hires_fb/gma.adb
View file

@ -59,9 +59,8 @@ is
success : boolean;
stride : Width_Type;
max_h : pos16 := 1;
max_v : pos16 := 1;
min_h : pos16 := pos16'last;
min_v : pos16 := pos16'last;
begin
lightup_ok := 0;
@ -77,30 +76,24 @@ is
for i in Config_Index loop
exit when configs (i).Port = Disabled;
max_h := pos16'max (max_h, configs (i).Mode.H_Visible);
max_v := pos16'max (max_v, configs (i).Mode.V_Visible);
min_h := pos16'min (min_h, configs (i).Mode.H_Visible);
min_v := pos16'min (min_v, configs (i).Mode.V_Visible);
end loop;
stride := ((Width_Type (max_h) + 63) / 64) * 64;
fb :=
(Width => Width_Type (min_h),
Height => Height_Type (min_v),
BPC => 8,
Stride => ((Width_Type (min_h) + 63) / 64) * 64,
Offset => 0);
for i in Config_Index loop
exit when configs (i).Port = Disabled;
configs (i).Framebuffer :=
(Width => Width_Type (configs (i).Mode.H_Visible),
Height => Height_Type (configs (i).Mode.V_Visible),
BPC => 8,
Stride => stride,
Offset => 0);
configs (i).Framebuffer := fb;
end loop;
HW.GFX.GMA.Dump_Configs (configs);
fb :=
(Width => Width_Type (max_h),
Height => Height_Type (max_v),
BPC => 8,
Stride => stride,
Offset => 0);
HW.GFX.GMA.Setup_Default_GTT (fb, phys_fb);
HW.GFX.Framebuffer_Filler.Fill (linear_fb, fb);