erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/xeon_sp: Drop DMAR_X2APIC_OPT_OUT

Browse source 
Drop DMAR_X2APIC_OPT_OUT since coreboot is able to enable X2APIC.

TEST: Works fine on OCP/tiogapass, thus drop the opt out.

Change-Id: Ia0443a39a9bf392976cfd1a7ccf6a335d5f0bd70
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85173
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shuo Liu <shuo.liu@intel.com>
This commit is contained in:
Patrick Rudolph 2024-11-18 09:41:24 +01:00 • committed by Lean Sheng Tan
commit 5ca1683b32
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/soc/intel/xeon_sp/uncore_acpi.c
View file

@ -588,11 +588,6 @@ unsigned long northbridge_write_acpi_tables(const struct device *device, unsigne
current = ALIGN_UP(current, 8);
dmar = (acpi_dmar_t *)current;
enum dmar_flags flags = DMAR_INTR_REMAP;
/* SKX FSP doesn't support X2APIC, but CPX FSP does */
if (CONFIG(SOC_INTEL_SKYLAKE_SP))
flags |= DMAR_X2APIC_OPT_OUT;
printk(BIOS_DEBUG, "ACPI: * DMAR at %lx\n", current);
printk(BIOS_DEBUG, "[DMA Remapping table] Flags: 0x%x\n", flags);
acpi_create_dmar(dmar, flags, acpi_fill_dmar);