From 5c53441738c8eb72da1f7caf5633ae9a94020d96 Mon Sep 17 00:00:00 2001 From: Kapil Porwal Date: Fri, 21 Feb 2025 19:25:35 +0530 Subject: [PATCH] mb/google/trulo: Update GPIO wake pins List of changes - 1. Make GPP_B3 IRQ only pin. 2. Remove redundant GPE option from touchpad device. BUG=b:397905085 TEST=Verified wake from S0ix using touchpad. Change-Id: I055a60476e4a37bf74940802157bb9cd30bac3c4 Signed-off-by: Kapil Porwal Reviewed-on: https://review.coreboot.org/c/coreboot/+/86555 Tested-by: build bot (Jenkins) Reviewed-by: Jayvik Desai Reviewed-by: Eric Lai Reviewed-by: Subrata Banik --- src/mainboard/google/brya/variants/trulo/gpio.c | 2 +- src/mainboard/google/brya/variants/trulo/overridetree.cb | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/variants/trulo/gpio.c b/src/mainboard/google/brya/variants/trulo/gpio.c index 3ccc54a3e2..fb805d6f28 100644 --- a/src/mainboard/google/brya/variants/trulo/gpio.c +++ b/src/mainboard/google/brya/variants/trulo/gpio.c @@ -58,7 +58,7 @@ static const struct pad_config gpio_table[] = { /* B2 : NC */ PAD_NC(GPP_B2, NONE), /* B3 : CPU_GP2 ==> EC_TP_INT */ - PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, PWROK, LEVEL, INVERT), + PAD_CFG_GPI_APIC(GPP_B3, NONE, PWROK, LEVEL, INVERT), /* B4 : PROC_GP3 ==> EN_PP3300_UCAM_X */ PAD_CFG_GPO_LOCK(GPP_B4, 1, LOCK_CONFIG), /* B5 : GPP_B5 ==> ISH_I2C0_SCL */ diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb index cdc777b0b0..4c21173a76 100644 --- a/src/mainboard/google/brya/variants/trulo/overridetree.cb +++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb @@ -455,7 +455,6 @@ chip soc/intel/alderlake register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ)" - register "wake" = "GPE0_DW1_03" register "detect" = "1" device i2c 15 on end end