erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drivers/spi: Get rid of spi_get_config

Browse source 
There is only one user for spi_get_config i.e. SPI ACPI. Also, the
values provided by spi_get_config are constant for now. Thus, get rid
of the spi_get_config call and fill in these constant values in SPI
ACPI code itself. If there is a need in the future to change these,
appropriate device-tree configs can be added.

BUG=b:36873582

Change-Id: Ied38e2670784ee3317bb12e542666c224bd9e819
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/19203
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins)
This commit is contained in:
Furquan Shaikh 2017-04-07 07:13:24 -07:00 • committed by Furquan Shaikh
commit 5bda642bcb
4 changed files with 8 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/include/spi-generic.h
View file

@ -90,7 +90,6 @@ struct spi_cfg {
/*-----------------------------------------------------------------------
* Representation of a SPI contoller.
*
* get_config: Get configuration of SPI bus
* claim_bus: Claim SPI bus and prepare for communication.
* release_bus: Release SPI bus.
* setup: Setup given SPI device bus.
@ -98,8 +97,6 @@ struct spi_cfg {
* xfer_vector: Vector of SPI transfer operations.
*/
struct spi_ctrlr {
int (*get_config)(const struct spi_slave *slave,
struct spi_cfg *cfg);
int (*claim_bus)(const struct spi_slave *slave);
void (*release_bus)(const struct spi_slave *slave);
int (*setup)(const struct spi_slave *slave);