From 5981272dcbb6648bf51f91c1d2ab67c18aa54992 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Wed, 3 Aug 2016 23:01:50 -0500 Subject: [PATCH] UPSTREAM: drivers/elog: remove unnecessary check in elog_shrink() There was a check against the next event offset against the shrink size in elog_shrink(). However, all calls to elog_shrink() were conditionalized on the next event offset exceeding the full threshold. The shrink size is set to the minimum of the full threshold and a percentage of the elog region size. Therefore, it's impossible for the next event offset to be less than the shrink size because full threshold is always greater than or equal to the shrink size. BUG=chrome-os-partner:55932 BRANCH=None TEST=None Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/16093 Reviewed-by: Furquan Shaikh Change-Id: Ie6ff106f1c53c15aa36a82223a235a7ac97fd8c7 Reviewed-on: https://chromium-review.googlesource.com/368284 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin --- src/drivers/elog/elog.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 59bc1de8d9..d8c7ff6336 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -352,9 +352,6 @@ static int elog_shrink(void) elog_debug("elog_shrink()\n"); - if (next_event_offset < shrink_size) - return 0; - while (1) { /* Next event has exceeded constraints */ if (offset > shrink_size)