From 58459b82108ecc3f72eb8968abca75a8e60fb2a4 Mon Sep 17 00:00:00 2001 From: Derek Huang Date: Wed, 1 Oct 2025 02:59:32 +0000 Subject: [PATCH] mb/var/uldrenite,orisa: Include the variant GPIO header In 76e0f640353a63b859770aebfdc7b2cbf3870662, it overrides GPIO_PCH_WP in variant/gpio.h, however gpio.c includes baseboard/gpio.h instead of variant/gpio.h. The wrong GPIO header causes the test firmware.WriteProtectCrossystem to fail with the wrong GPIO_PCH_WP pin number. Corrects the header file included in gpio.c to fix the issue. BUG=b:448313028 TEST=Pass firmware.WriteProtectCrossystem Change-Id: I94b2384d03f8ce83f662a2b9dba4039f3d551b07 Signed-off-by: Derek Huang Reviewed-on: https://review.coreboot.org/c/coreboot/+/89389 Reviewed-by: Eric Lai Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/variants/orisa/gpio.c | 2 +- src/mainboard/google/brya/variants/uldrenite/gpio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/variants/orisa/gpio.c b/src/mainboard/google/brya/variants/orisa/gpio.c index 6f45dcc589..1801e82fdb 100644 --- a/src/mainboard/google/brya/variants/orisa/gpio.c +++ b/src/mainboard/google/brya/variants/orisa/gpio.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include #include #include #include #include +#include /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = { diff --git a/src/mainboard/google/brya/variants/uldrenite/gpio.c b/src/mainboard/google/brya/variants/uldrenite/gpio.c index d21b0ebde3..57f9e94cf5 100644 --- a/src/mainboard/google/brya/variants/uldrenite/gpio.c +++ b/src/mainboard/google/brya/variants/uldrenite/gpio.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include #include #include #include #include +#include /* Pad configuration in ramstage */ static const struct pad_config gpio_table[] = {