From 582f7c43743fe23a371a3b7e56a6b145bd499718 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 28 Jan 2025 14:07:05 +0000 Subject: [PATCH] mb/starlabs/*: Correct config for SATA DEVSLP GPIO On boards that do not use SATA, this should be connected. For boards that do use it, it should be NF5. Change-Id: I3115627431e80bd5e0f91b53b80fac7c0c95e6f8 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86186 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c | 2 +- src/mainboard/starlabs/starbook/variants/adl/gpio.c | 2 +- src/mainboard/starlabs/starbook/variants/mtl/gpio.c | 1 + src/mainboard/starlabs/starfighter/variants/rpl/gpio.c | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index f4d7ab0703..35d9489070 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -362,7 +362,7 @@ const struct pad_config gpio_table[] = { /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ - PAD_CFG_GPO(GPP_H13, 0, PLTRST), + PAD_CFG_NF(GPP_H13, NONE, DEEP, NF5), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), /* H15: DDPB Control Clock */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 21821be1ca..77be325ebf 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -361,7 +361,7 @@ const struct pad_config gpio_table[] = { /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ - PAD_CFG_GPO(GPP_H13, 0, PLTRST), + PAD_CFG_NF(GPP_H13, NONE, DEEP, NF5), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), /* H15: DDPB Control Clock */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index b3ed9e26e7..fd4a0900d4 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -202,6 +202,7 @@ const struct pad_config gpio_table[] = { /* E03: */ PAD_NC(GPP_E03, NONE), /* E04: M.2_SSD_DEVSLP0 */ + PAD_NC(GPP_E04, NONE), /* E05: */ PAD_NC(GPP_E05, NONE), /* E06: JTAG ODT diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index e0e6164905..18c5651fdb 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -358,7 +358,7 @@ const struct pad_config gpio_table[] = { /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ - PAD_CFG_GPO(GPP_H13, 0, PLTRST), + PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), /* H15: DDPB Control Clock */