From 57e30e6b9db19d21bfbb56f09bbc32c17e89ab1f Mon Sep 17 00:00:00 2001 From: Kenneth Chan Date: Wed, 4 Feb 2026 18:15:01 +0800 Subject: [PATCH] mb/google/brask/var/moxoe: Switch memory to DDR5 Moxoe uses DDR5 SODIMM. Configure the board to support DDR5. BUG=b:481186489 TEST=Builds successfully for moxoe. Change-Id: Ic2f35dab77c24863cf63f6672ba14cbb560edf14 Signed-off-by: Kenneth Chan Reviewed-on: https://review.coreboot.org/c/coreboot/+/91089 Reviewed-by: Ren Kuo Tested-by: build bot (Jenkins) --- .../google/brya/variants/moxoe/Makefile.mk | 1 + .../google/brya/variants/moxoe/memory.c | 45 +++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 src/mainboard/google/brya/variants/moxoe/memory.c diff --git a/src/mainboard/google/brya/variants/moxoe/Makefile.mk b/src/mainboard/google/brya/variants/moxoe/Makefile.mk index e31aaa1707..2b274c69e2 100644 --- a/src/mainboard/google/brya/variants/moxoe/Makefile.mk +++ b/src/mainboard/google/brya/variants/moxoe/Makefile.mk @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only bootblock-y += gpio.c +romstage-y += memory.c romstage-y += gpio.c ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/moxoe/memory.c b/src/mainboard/google/brya/variants/moxoe/memory.c new file mode 100644 index 0000000000..742ce7fe3a --- /dev/null +++ b/src/mainboard/google/brya/variants/moxoe/memory.c @@ -0,0 +1,45 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include +#include +#include + +static const struct mb_cfg ddr5_mem_config = { + .type = MEM_TYPE_DDR5, + + .rcomp = { + /* Baseboard uses only 100ohm Rcomp resistors */ + .resistor = 100, + + /* Baseboard Rcomp target values */ + .targets = {50, 20, 25, 25, 25}, + }, + + .LpDdrDqDqsReTraining = 1, + + .ect = 1, /* Early Command Training */ + + .UserBd = BOARD_TYPE_MOBILE, + + .ddr_config = { + .dq_pins_interleaved = false, + }, +}; + +const struct mb_cfg *__weak variant_memory_params(void) +{ + return &ddr5_mem_config; +} + +bool __weak variant_is_half_populated(void) +{ + return false; +} + +void __weak variant_get_spd_info(struct mem_spd *spd_info) +{ + spd_info->topo = MEM_TOPO_DIMM_MODULE; + spd_info->smbus[0].addr_dimm[0] = 0x50; + spd_info->smbus[1].addr_dimm[0] = 0x52; +}