From 5775ed215e59fe0d45b422e19458e63f7d46329e Mon Sep 17 00:00:00 2001 From: Simon Yang Date: Sun, 20 Oct 2024 17:54:02 +0800 Subject: [PATCH] soc/intel/alderlake_n: Fix display flicker issue when using internal FIVR If project set configure_ext_fivr = 0 will cause PchFivrVccstIccMaxControl do not set correctly. BUG=b:361831628 TEST=Verified on Teliks360 that affected DUTs. Change-Id: I816de9c0c507aad3b73ab29e9f72048704f4662d Signed-off-by: Simon Yang Reviewed-on: https://review.coreboot.org/c/coreboot/+/84812 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Qinghong Zeng Reviewed-by: V Sowmya --- src/soc/intel/alderlake/fsp_params.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 41d048b68f..839d161eae 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -1200,6 +1200,15 @@ static void fill_fsps_irq_params(FSP_S_CONFIG *s_cfg, static void fill_fsps_fivr_params(FSP_S_CONFIG *s_cfg, const struct soc_intel_alderlake_config *config) { +#if CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) + /* Enable the FIVR VCCST ICCMax Control for ADL-N. + * TODO:Right now the UPD is update in partial headers for only ADL-N and when its + * updated for ADL-P then we will remove the config since this needs to be enabled for + * all the Alderlake platforms. + */ + s_cfg->PchFivrVccstIccMaxControl = 1; +#endif + /* PCH FIVR settings override */ if (!config->ext_fivr_settings.configure_ext_fivr) return; @@ -1234,15 +1243,6 @@ static void fill_fsps_fivr_params(FSP_S_CONFIG *s_cfg, s_cfg->PchFivrExtVnnRailIccMaximum = config->ext_fivr_settings.vnn_icc_max_ma; - -#if CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) - /* Enable the FIVR VCCST ICCMax Control for ADL-N. - * TODO:Right now the UPD is update in partial headers for only ADL-N and when its - * updated for ADL-P then we will remove the config since this needs to be enabled for - * all the Alderlake platforms. - */ - s_cfg->PchFivrVccstIccMaxControl = 1; -#endif } static void fill_fsps_fivr_rfi_params(FSP_S_CONFIG *s_cfg,