From 56013ce0ff12546997b85b8334544a6bf4d15043 Mon Sep 17 00:00:00 2001 From: Venkateshwar S Date: Tue, 30 Dec 2025 02:05:55 -0800 Subject: [PATCH] mainboard/google/bluey: Skip SHRM firmware load/reset in ramdump mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The SHRM firmware load and reset sequence currently runs unconditionally during the boot process. This causes issues during RAM dump collection, where the contents of the SHRM region must remain intact for post‑crash analysis. This patch adds a Dload‑mode check (which indicates RAM‑dump mode) and skips shrm_fw_load_reset() when that bit is set. This prevents unintended SHRM resets during RAM dump capture and ensures the firmware load/reset sequence only runs during a normal cold boot. A RAM dump is a debug image used after a crash to preserve system memory for post‑crash analysis. Test=Create an image.serial.bin and ensure it boots on X1P42100. Change-Id: Ie3d1ff9462a48d21f1daae1f80322ea397731be5 Signed-off-by: Venkateshwar S Reviewed-on: https://review.coreboot.org/c/coreboot/+/90651 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/bluey/romstage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/bluey/romstage.c b/src/mainboard/google/bluey/romstage.c index 3ada667376..06cd5626bd 100644 --- a/src/mainboard/google/bluey/romstage.c +++ b/src/mainboard/google/bluey/romstage.c @@ -94,7 +94,8 @@ void platform_romstage_main(void) if (CONFIG(EC_GOOGLE_CHROMEEC) && CONFIG(CONSOLE_SERIAL)) platform_dump_battery_soc_information(); - shrm_fw_load_reset(); + if (!qclib_check_dload_mode()) + shrm_fw_load_reset(); /* QCLib: DDR init & train */ qclib_load_and_run();