erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: chromeos: fix build issues within sar.c

Browse source 
Build issues were somehow overlooked in commit
ed840023a8:
1. hexstrtobin is not defined (needs the lib.h);
2. coreboot default compiler doesn't like variable initialization
   within for loop.

BUG=chrome-os-partner:60821
TEST=Build and boot lars and reef

Change-Id: Iaf8ccf86e3b53fac481f28356d838728149d3e49
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id:
Original-Change-Id: I85b1394956ceb9b64e1b72f9f71982b6205d5a99
Original-Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Original-Commit-Id: feb4ef6d92
Original-Original-Change-Id: Ie52c1f93eee7d739b8aaf59604875f179dff60d0
Original-Original-Signed-off-by: Robbie Zhang <robbie.zhang@intel.com>
Original-Original-Reviewed-on: https://review.coreboot.org/18076
Original-Original-Tested-by: build bot (Jenkins)
Original-Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/428251
Commit-Ready: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Robbie Zhang 2017-01-09 15:28:24 -08:00 • committed by chrome-bot
commit 5504cb5097
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/vendorcode/google/chromeos/sar.c
View file

@ -13,6 +13,7 @@
* GNU General Public License for more details.
*/
#include <console/console.h>
#include <lib.h>
#include <types.h>
#include <string.h>
#include <sar.h>
@ -31,6 +32,7 @@ int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits)
sizeof(uint8_t)) * 2 + 1;
char wifi_sar_limit_str[buffer_size];
uint8_t bin_buffer[sizeof(struct wifi_sar_limits)];
int i;
/* Try to read the SAR limit entry from VPD */
if (!cros_vpd_gets(wifi_sar_limit_key, wifi_sar_limit_str,
@ -52,7 +54,7 @@ int get_wifi_sar_limits(struct wifi_sar_limits *sar_limits)
}
/* Fill the sar_limits structure with the decoded data */
for (int i = 0; i < NUM_SAR_LIMITS; i++)
for (i = 0; i < NUM_SAR_LIMITS; i++)
memcpy(sar_limits->sar_limit[i],
&bin_buffer[BYTES_PER_SAR_LIMIT * i],
BYTES_PER_SAR_LIMIT);