From 532543027ae43ec2b7f4a74d44b1017f194332a4 Mon Sep 17 00:00:00 2001 From: Uwe Poeche Date: Thu, 15 Jan 2026 14:03:03 +0100 Subject: [PATCH] mb/siemens/{mc_ehl6,mc_ehl7}: Configure GPIO GPP_G5 (SD CD) pull-up On mc_ehl6/7 mainboards, the internal GPIO pull-up is required for the SD card "Card Detect" signal to function properly. This patch updates the GPIO configuration accordingly. TEST=Booted mc_ehl6 and verified the voltage level at the relevant pin before and after the patch. Change-Id: I96a381f100dd9886ced030434316125d60a13a72 Signed-off-by: Uwe Poeche Reviewed-on: https://review.coreboot.org/c/coreboot/+/90769 Reviewed-by: Mario Scheithauer Tested-by: build bot (Jenkins) --- src/mainboard/siemens/mc_ehl/variants/mc_ehl6/gpio.c | 1 + src/mainboard/siemens/mc_ehl/variants/mc_ehl7/gpio.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl6/gpio.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl6/gpio.c index 49f737b868..4ec42c02cf 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl6/gpio.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl6/gpio.c @@ -27,6 +27,7 @@ static const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_T13, NONE, DEEP, NF2), /* SIO_UART0_TXD */ /* Community 0 - GpioGroup GPP_G */ + PAD_CFG_NF(GPP_G5, UP_20K, DEEP, NF1), /* SD Card Detect */ PAD_NC(GPP_G8, NONE), /* Not connected */ PAD_NC(GPP_G9, NONE), /* Not connected */ PAD_CFG_GPI(GPP_G19, UP_20K, PLTRST), /* TPM_IRQ_N */ diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/gpio.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/gpio.c index 49f737b868..18997f7c0f 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/gpio.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/gpio.c @@ -27,6 +27,7 @@ static const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_T13, NONE, DEEP, NF2), /* SIO_UART0_TXD */ /* Community 0 - GpioGroup GPP_G */ + PAD_CFG_NF(GPP_G5, UP_20K, DEEP, NF1), /* SD Card Detect */ PAD_NC(GPP_G8, NONE), /* Not connected */ PAD_NC(GPP_G9, NONE), /* Not connected */ PAD_CFG_GPI(GPP_G19, UP_20K, PLTRST), /* TPM_IRQ_N */