erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/var/trulo: Remove touchscreen definitions

Browse source 
Remove touchscreen definitions for Trulo since it doesn't have any.
Additionally, disable unused I2C controller 5.

BUG=none
TEST=Build trulo firmware image

Change-Id: If9d00ebf6165449d96f9337f313ee83262507ab4
Signed-off-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85893
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jayvik Desai <jayvik@google.com>
Reviewed-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
Reviewed-by: Eric Lai <ericllai@google.com>
This commit is contained in:
Kapil Porwal 2025-01-08 17:17:59 +05:30 • committed by Subrata Banik
commit 52f20d13cc
2 changed files with 9 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/mainboard/google/brya/variants/trulo/gpio.c
View file

@ -44,8 +44,8 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_A19, NONE),
/* A20 : NC */
PAD_NC(GPP_A20, NONE),
/* A21 : DDPC_CTRLCLK ==> TCHSCR_REPORT_EN */
PAD_CFG_GPO(GPP_A21, 0, DEEP),
/* A21 : NC */
PAD_NC(GPP_A21, NONE),
/* A22 : GPP_A22 ==> TPM_PIRQ# */
PAD_CFG_GPI(GPP_A22, NONE, DEEP),
/* A23 : GPP_A23 ==> NC */
@ -147,10 +147,10 @@ static const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPP_D13, NONE, DEEP, NF1),
/* D14 : UART0_ISH_TX_DBG_RX */
PAD_CFG_NF(GPP_D14, NONE, DEEP, NF1),
/* D15 : GPP_D15 ==> SOC_TS_I2C_RST# */
PAD_CFG_GPO_LOCK(GPP_D15, 1, LOCK_CONFIG),
/* D16 : ISH_UART0_CTS# ==> SOC_TS_I2C_INT# */
PAD_CFG_GPI_LOCK(GPP_D16, NONE, LOCK_CONFIG),
/* D15 : NC */
PAD_NC(GPP_D15, NONE),
/* D16 : NC */
PAD_NC(GPP_D16, NONE),
/* D17 : NC */
PAD_NC_LOCK(GPP_D17, NONE, LOCK_CONFIG),
/* D18 : NC */
@ -192,8 +192,8 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_E15, NONE),
/* E16 : NC */
PAD_NC(GPP_E16, NONE),
/* E17 : GPP_E17 ==> SOC_TS_PWR_EN */
PAD_CFG_GPO_LOCK(GPP_E17, 1, LOCK_CONFIG),
/* E17 : NC */
PAD_NC(GPP_E17, NONE),
/* E18 : NC */
PAD_NC(GPP_E18, NONE),
/* E19 : DDP1_CTRLDATA ==> GPP_E19_STRAP */
@ -432,11 +432,6 @@ static const struct pad_config early_gpio_table[] = {
/* Fill romstage gpio configuration */
static const struct pad_config romstage_gpio_table[] = {
/* Enable touchscreen, hold in reset */
/* E17 : GPP_E17 ==> SOC_TS_PWR_EN */
PAD_CFG_GPO(GPP_E17, 1, DEEP),
/* D15 : GPP_D15 ==> SOC_TS_I2C_RST# */
PAD_CFG_GPO(GPP_D15, 0, DEEP),
};
const struct pad_config *variant_gpio_table(size_t *num)

31
src/mainboard/google/brya/variants/trulo/overridetree.cb
View file

@ -122,7 +122,7 @@ chip soc/intel/alderlake
[PchSerialIoIndexI2C2] = PchSerialIoDisabled,
[PchSerialIoIndexI2C3] = PchSerialIoDisabled,
[PchSerialIoIndexI2C4] = PchSerialIoDisabled,
[PchSerialIoIndexI2C5] = PchSerialIoPci,
[PchSerialIoIndexI2C5] = PchSerialIoDisabled,
}"
register "serial_io_gspi_mode" = "{
@ -148,7 +148,6 @@ chip soc/intel/alderlake
#| | required to set up a BAR |
#| | for TPM communication |
#| I2C1 | Trackpad |
#| I2C5 | Touchscreen |
#+-------------------+---------------------------+
register "common_soc_config" = "{
.i2c[0] = {
@ -170,15 +169,6 @@ chip soc/intel/alderlake
.sda_hold = 7,
}
},
.i2c[5] = {
.speed = I2C_SPEED_FAST,
.speed_config[0] = {
.speed = I2C_SPEED_FAST,
.scl_lcnt = 158,
.scl_hcnt = 79,
.sda_hold = 7,
}
},
}"
device domain 0 on
@ -470,25 +460,6 @@ chip soc/intel/alderlake
device i2c 15 on end
end
end #I2C1
device ref i2c5 on
chip drivers/i2c/hid
register "generic.hid" = ""ELAN9004""
register "generic.desc" = ""ELAN Touchscreen""
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D16_IRQ)"
register "generic.detect" = "1"
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)"
register "generic.reset_delay_ms" = "20"
register "generic.reset_off_delay_ms" = "2"
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E17)"
register "generic.enable_delay_ms" = "1"
register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A21)"
register "generic.stop_delay_ms" = "150"
register "generic.stop_off_delay_ms" = "2"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x01"
device i2c 10 on end
end
end #I2C5
device ref heci1 on end
device ref emmc on
probe STORAGE STORAGE_UNKNOWN