From 507b577b1560c7f34ad7f7a1273219d02a3e0c76 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Tue, 17 Jan 2017 18:27:42 -0600 Subject: [PATCH] UPSTREAM: nb/amd/ddr3: Make the maximum CDD a signed value max_cdd_we_delta should be signed to allow for negative CDD. BUG=none BRANCH=none TEST=none Change-Id: I25b6d05504da5cce4f1e75b32ecdf16b450c1f59 Signed-off-by: Patrick Georgi Original-Commit-Id: 9b4c888f7bb91ea5034802ab381f87c4c9729ad9 Original-Found-by: Coverity Scan #1347355 Original-Change-Id: Iaccd1021680296d169c26c25e339f83fbd7cc065 Original-Signed-off-by: Timothy Pearson Original-Reviewed-on: https://review.coreboot.org/18162 Original-Tested-by: build bot (Jenkins) Original-Tested-by: Raptor Engineering Automated Test Stand Original-Reviewed-by: Paul Menzel Original-Reviewed-by: Nico Huber Reviewed-on: https://chromium-review.googlesource.com/430733 --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index b64ad54711..1ac91a1fb2 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3027,7 +3027,7 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat, /* Disable training mode */ uint8_t lane; uint8_t dimm; - uint16_t max_cdd_we_delta; + int16_t max_cdd_we_delta; int16_t cdd_trwtto_we_delta; uint8_t receiver; uint8_t lane_count;