From 4fc5f7a843afad33a758c9aa3d9f747d5f1a2322 Mon Sep 17 00:00:00 2001 From: Hualin Wei Date: Fri, 5 Sep 2025 15:06:40 +0800 Subject: [PATCH] mb/google/fatcat/var/lapis: Modify the gpio order of mem_id According to the schematic diagram of lapis, refer to the design of fatcat and modify the gpio order of mem_id. BUG=b:438785495 TEST=emerge-fatcat coreboot Change-Id: I715634e231725bbd009b35a0c520d19a894f569c Signed-off-by: Hualin Wei Reviewed-on: https://review.coreboot.org/c/coreboot/+/89066 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Eric Lai Reviewed-by: Weimin Wu --- src/mainboard/google/fatcat/variants/lapis/memory.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/lapis/memory.c b/src/mainboard/google/fatcat/variants/lapis/memory.c index 4e2a1536ae..0c2a4e79fd 100644 --- a/src/mainboard/google/fatcat/variants/lapis/memory.c +++ b/src/mainboard/google/fatcat/variants/lapis/memory.c @@ -74,17 +74,15 @@ int variant_memory_sku(void) /* * Memory configuration board straps * MEM_STRAP_0 GPP_A13 + * DIMM_SEL1 GPP_D24 (MEM_STRAP_1) + * DIMM_SEL2 GPP_B25 (MEM_STRAP_2) * MEM_STRAP_3 GPP_B24 - * DIMM_SEL0 GPP_D25 - * DIMM_SEL1 GPP_D24 - * DIMM_SEL2 GPP_B25 */ gpio_t spd_gpios[] = { GPP_A13, - GPP_B24, - GPP_D25, GPP_D24, GPP_B25, + GPP_B24, }; return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios));