From 4f1a1adef638e15b14d49a25ff6142dfd6a43800 Mon Sep 17 00:00:00 2001 From: Alicja Michalska Date: Mon, 16 Dec 2024 21:50:52 +0100 Subject: [PATCH] mb/topton/adl: Disable mapped SATA port According to Intel mFIT tool, SATA Port 0 is mapped as RP11 (PCI-E). Disable SATA mapping on that port. Setting SATAXPCIE1 GPIO fixes broken SATA port. Therefore, this port is now fully functional. TEST: Plug in 2.5in SATA drive, check detection in EDK2/Linux. Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Signed-off-by: Alicja Michalska Reviewed-on: https://review.coreboot.org/c/coreboot/+/85609 Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) --- src/mainboard/topton/adl/devicetree.cb | 3 --- src/mainboard/topton/adl/gpio.h | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/mainboard/topton/adl/devicetree.cb b/src/mainboard/topton/adl/devicetree.cb index f21687a481..5dcca690b4 100644 --- a/src/mainboard/topton/adl/devicetree.cb +++ b/src/mainboard/topton/adl/devicetree.cb @@ -42,11 +42,8 @@ chip soc/intel/alderlake end device ref shared_sram on end - - # Not working, resource conflict(?) device ref sata on register "sata_ports_enable" = "{ - [0] = 1, [1] = 1, }" end diff --git a/src/mainboard/topton/adl/gpio.h b/src/mainboard/topton/adl/gpio.h index 6b990c274d..ffc528c575 100644 --- a/src/mainboard/topton/adl/gpio.h +++ b/src/mainboard/topton/adl/gpio.h @@ -68,7 +68,7 @@ static const struct pad_config gpio_table[] = { _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K) | PAD_IOSSTATE(IGNORE)), /* ESPI_CLK */ _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(IGNORE)), /* ESPI_RESET# */ PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* GPIO */ - PAD_NC(GPP_A12, NONE), /* GPIO */ + PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* SATAXPCIE1 */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* GPIO */ _PAD_CFG_STRUCT(GPP_A14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_IOSSTATE(IGNORE)), /* USB_OC1# */ _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(IOAPIC) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */