From 4ef7804bc4ec957dff23390e85ae931b66ee4c30 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 6 Feb 2025 20:39:03 +0000 Subject: [PATCH] mb/starlabs/starbook/mtl: Add rcomp configuration Add rcomp configuration values taken from the AMI CRB. This fixes failed memory training for certain memory modules. Change-Id: If7a29bbd015d45eac178480ba6cae42912e25195 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86307 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/starlabs/starbook/variants/mtl/romstage.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c index 14b2664cbd..26a4e5eb3c 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/romstage.c @@ -13,6 +13,10 @@ void mainboard_memory_init_params(FSPM_UPD *mupd) .UserBd = BOARD_TYPE_MOBILE, .ddr_config = { .dq_pins_interleaved = false, + }, + .rcomp = { + .resistor = 100, + .targets = {70, 30, 25, 25, 25}, } };