erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/xeon_sp: Advertise DIMMs on skylake_sp as well

Browse source 
Add the MEMMAP_DIMM_DEVICE_INFO_STRUCT for skylake_sp and let common
code fill in the SMBIOS type 17 entries for all slots and found DIMMs.

This also allows to build dimm.c unconditionally on all xeon_sp socs.

Test: On ocp/tiogapass all DIMMs and slots are visible in SMBIOS.

Change-Id: I686b1e3ef946240785111f86a5f23a109a6a52ad
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85319
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Patrick Rudolph 2024-11-26 09:45:04 +01:00
commit 4ce5304879
6 changed files with 73 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/vendorcode/intel/fsp/fsp2_0/skylake_sp/hob_memmap.h
View file

@ -36,6 +36,15 @@ are permitted provided that the following conditions are met:
0xbd, 0x56, 0xda, 0x91, 0xc0, 0x7f \
}
#define CH_INDEPENDENT 0
#define FULL_MIRROR_1LM BIT0
#define FULL_MIRROR_2LM BIT1
#define CH_LOCKSTEP BIT2
#define RK_SPARE BIT3
#define PARTIAL_MIRROR_1LM BIT5
#define PARTIAL_MIRROR_2LM BIT6
#define STAT_VIRT_LOCKSTEP BIT7
#define MEMTYPE_1LM_MASK (1 << 0)
#define MEMTYPE_2LM_MASK (1 << 1)
#define MEMTYPE_VOLATILE_MASK (MEMTYPE_1LM_MASK | MEMTYPE_2LM_MASK)
@ -50,6 +59,34 @@ are permitted provided that the following conditions are met:
#pragma pack(1)
typedef struct DimmDevice {
UINT8 Present;
UINT8 reserved1[3];
UINT8 NumRanks;
UINT8 reserved2[1];
UINT8 actKeyByte2;
UINT8 reserved3[9];
UINT16 DimmSize;
UINT8 reserved4[8];
UINT16 VendorID;
UINT16 DeviceID;
UINT8 reserved5[24];
UINT8 serialNumber[4];
UINT8 PartNumber[4];
UINT8 reserved6[50];
INT32 commonTck;
UINT8 reserved7[24];
} MEMMAP_DIMM_DEVICE_INFO_STRUCT;
struct ChannelDevice {
UINT8 reserved1[191];
MEMMAP_DIMM_DEVICE_INFO_STRUCT DimmInfo[MAX_IMC];
};
typedef struct socket {
UINT8 reserved[2075];
struct ChannelDevice ChannelInfo[MAX_CH];
} MEMMAP_SOCKET;
struct SystemMemoryMapElement {
UINT8 NodeId; // Node ID of the HA Owning the memory
UINT8 SocketId; // Socket Id of socket that has his memory - ONLY IN NUMA
@ -98,7 +135,7 @@ struct SystemMemoryMapHob {
UINT8 maxCh;
struct SystemMemoryMapElement Element[MAX_SOCKET * SAD_RULES];
UINT8 reserved1[982];
UINT8 reserved2[4901*MAX_SOCKET];
MEMMAP_SOCKET Socket[MAX_SOCKET];
UINT8 reserved3[707];
};