From 4b93b36170720fa84e3d892fc215f7d4703b2e6f Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Mon, 29 Sep 2025 20:21:39 +0900 Subject: [PATCH] mb/purism: add missing terminators to azalia codec tables This was supposed to be checked in the regression test script (CB:88763), however it turns out Valgrind's Memcheck only works on the heap memory and is unable to catch such errors. The regression test script was modified to use AddressSanitizer which can catch such errors, so this should not be a problem in subsequent changes during the verb table rework. To be safe, the previously merged commits were also checked with the new regression test script: f634121fa476 ("mb/purism: Replace verb tables with reworked implementation") 20d404245832 ("mb/asrock: Replace verb tables with reworked implementation") 2b7dbf80c981 ("mb/apple: Replace verb tables with reworked implementation") 970249694f85 ("mb/amd: Replace verb tables with reworked implementation") 94beaa7ab313 ("mb/acer: Replace verb tables with reworked implementation") f3db3a19d5cb ("mb/51nb: Replace verb tables with reworked implementation") However, the following mini-HD code was checked manually, as figuring out how to strip out minihd_init() was not worth the effort: bc92d9a66666 ("nb/intel/haswell/minihd.c: Add reworked verb table implementation") 69781b980680 ("soc/intel/broadwell/minihd.c: Add reworked verb table implementation") Change-Id: Iea964fb8b92814b57d4c82412c47cf31fa48de66 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/89376 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/mainboard/purism/librem_bdw/hda_verb.c | 1 + src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c | 1 + src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c | 1 + src/mainboard/purism/librem_jsl/hda_verb.c | 1 + src/mainboard/purism/librem_skl/hda_verb.c | 1 + 5 files changed, 5 insertions(+) diff --git a/src/mainboard/purism/librem_bdw/hda_verb.c b/src/mainboard/purism/librem_bdw/hda_verb.c index 1cf41265d7..053088d671 100644 --- a/src/mainboard/purism/librem_bdw/hda_verb.c +++ b/src/mainboard/purism/librem_bdw/hda_verb.c @@ -28,6 +28,7 @@ struct azalia_codec mainboard_azalia_codecs[] = { .verbs = realtek_alc269_verbs, .verb_count = ARRAY_SIZE(realtek_alc269_verbs), }, + { /* terminator */ } }; AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c b/src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c index 912f955710..7d95f8130f 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c @@ -116,6 +116,7 @@ struct azalia_codec mainboard_azalia_codecs[] = { .verbs = intel_display_audio_verbs, .verb_count = ARRAY_SIZE(intel_display_audio_verbs), }, + { /* terminator */ } }; AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c index 978a33c57d..07de4900c8 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/hda_verb.c @@ -44,6 +44,7 @@ struct azalia_codec mainboard_azalia_codecs[] = { .verbs = intel_display_audio_verbs, .verb_count = ARRAY_SIZE(intel_display_audio_verbs), }, + { /* terminator */ } }; AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/purism/librem_jsl/hda_verb.c b/src/mainboard/purism/librem_jsl/hda_verb.c index 293b090e94..aaac56361e 100644 --- a/src/mainboard/purism/librem_jsl/hda_verb.c +++ b/src/mainboard/purism/librem_jsl/hda_verb.c @@ -67,6 +67,7 @@ struct azalia_codec mainboard_azalia_codecs[] = { .verbs = intel_display_audio_verbs, .verb_count = ARRAY_SIZE(intel_display_audio_verbs), }, + { /* terminator */ } }; AZALIA_ARRAY_SIZES; diff --git a/src/mainboard/purism/librem_skl/hda_verb.c b/src/mainboard/purism/librem_skl/hda_verb.c index e308482497..0b61fb12f9 100644 --- a/src/mainboard/purism/librem_skl/hda_verb.c +++ b/src/mainboard/purism/librem_skl/hda_verb.c @@ -28,6 +28,7 @@ struct azalia_codec mainboard_azalia_codecs[] = { .verbs = realtek_alc269_verbs, .verb_count = ARRAY_SIZE(realtek_alc269_verbs), }, + { /* terminator */ } }; AZALIA_ARRAY_SIZES;