From 4ae5366ba25ffc59abe4c307579701009ba77487 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Fri, 30 Jan 2026 09:36:07 +0100 Subject: [PATCH] cpu/intel/smm/gen1/smmrelocate: Fix comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code was copied from newer generation SoC supporting parallel SMM relocation, but it wasn't properly cleaned. Gen1 doesn't support parallel SMM relocation, so fix the comments. Change-Id: Idbe6d2c18f668a9c1922b93ce1b2cc3d126ff2f9 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/91013 Reviewed-by: Jérémy Compostella Tested-by: build bot (Jenkins) --- src/cpu/intel/smm/gen1/smmrelocate.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index 8dffceb4fd..c57a661ef7 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -145,10 +145,7 @@ void smm_initialize(void) /* Clear the SMM state in the southbridge. */ smm_southbridge_clear_state(); - /* - * Run the relocation handler for on the BSP to check and set up - * parallel SMM relocation. - */ + /* Run the relocation handler on the BSP. */ smm_initiate_relocation(); } @@ -195,20 +192,11 @@ void smm_relocation_handler(int cpu, uintptr_t curr_smbase, write_smrr(relo_params); } -/* - * The default SMM entry can happen in parallel or serially. If the - * default SMM entry is done in parallel the BSP has already setup - * the saving state to each CPU's MSRs. At least one save state size - * is required for the initial SMM entry for the BSP to determine if - * parallel SMM relocation is even feasible. - */ void smm_relocate(void) { /* - * If smm_save_state_in_msrs is non-zero then parallel SMM relocation - * shall take place. Run the relocation handler a second time on the - * BSP to do the final move. For APs, a relocation handler always - * needs to be run. + * The BSP had already run SMM relocation in smm_initialize(), + * so skip it for the BSP and only run it on the APs. */ if (!boot_cpu()) smm_initiate_relocation();