UPSTREAM: buildgcc: Never set GMP CFLAGS manually in order to get the right flags
When no CFLAGS are explicitly provided to it, the GMP configure script will figure out the best optimization flags to use on its own. In particular, it will setup the march, mfpu and mtune flags based on hardware detection. However, when CFLAGS are provided, they are used as-is and such detection doesn't happen. When the march, mfpu and mtune flags are not provided (which happens when GMP wasn't built already), not only will related optimizations be disabled, but some code might not build because of missing support. This happens with NEON instructions on ARMv7 hosts. Thus, it is better not to set CFLAGS and leave it up to the GMP configure script to get them right and still reuse those later. BUG=None BRANCH=None TEST=None Signed-off-by: Paul Kocialkowski <contact@paulk.fr> Reviewed-on: https://review.coreboot.org/15452 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de> Change-Id: I6ffcbac1298523d1b8ddf29a8bca1b00298828a7 Reviewed-on: https://chromium-review.googlesource.com/362341 Commit-Ready: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org>
This commit is contained in:
parent
3abe77a9cb
commit
4a525a2a76
1 changed files with 1 additions and 2 deletions
|
|
@ -440,8 +440,7 @@ set_hostcflags_from_gmp() {
|
|||
}
|
||||
|
||||
build_GMP() {
|
||||
CC="$CC" CFLAGS="$HOSTCFLAGS" \
|
||||
../${GMP_DIR}/configure --disable-shared --enable-fat \
|
||||
CC="$CC" ../${GMP_DIR}/configure --disable-shared --enable-fat \
|
||||
--prefix=$TARGETDIR $OPTIONS \
|
||||
|| touch .failed
|
||||
$MAKE $JOBS || touch .failed
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue