erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/qc/x1p42100: Allow building QC platform without upstream blobs

Browse source 
Qualcomm's latest SoC, the x1p42100, lacks upstreamed blobs. This
prevents coreboot builds because the default setting marks
CONFIG_USE_QC_BLOBS=y. As a result, build errors occur when the new
Qualcomm SoC blobs aren't in the upstream.

This change introduces `QC_BLOBS_UPSTREAM` Kconfig and set to default
`N` to build QC platform without relying on upstream blob support.
This is necessary for bringing up a new QC SoC-based platform, as
public QC blobs won't be available until later in the year. This
ensures that early QC development can proceed for QC SoC based
without depending on upstream blobs.

Override this Kconfig when QC blobs are available in upstream for
latest X1P42100 SoC.

TEST=Able to build google/bluey.

Change-Id: I04fde6e8917fb3f88c58eb2b55b47de1c2d33518
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88137
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Subrata Banik 2025-06-21 07:16:09 +00:00
commit 4a2c61a8a0
2 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/soc/qualcomm/x1p42100/Kconfig
View file

@ -3,7 +3,6 @@
config SOC_QUALCOMM_X1P42100
bool
default n
depends on USE_QC_BLOBS
select ARCH_BOOTBLOCK_ARMV8_64
select ARCH_RAMSTAGE_ARMV8_64
select ARCH_ROMSTAGE_ARMV8_64
@ -28,6 +27,13 @@ config SOC_QUALCOMM_X1P42100
if SOC_QUALCOMM_X1P42100
config QC_BLOBS_UPSTREAM
bool "QC blobs are available in upstream repository"
select USE_QC_BLOBS
default n
help
Select based on availability of QC blobs in upstream coreboot `3rdparty/qc_blobs`.
config MEMLAYOUT_LD_FILE
string
default "src/soc/qualcomm/x1p42100/memlayout.ld"

9
src/soc/qualcomm/x1p42100/Makefile.mk
View file

@ -47,9 +47,11 @@ CPPFLAGS_common += -Isrc/soc/qualcomm/x1p42100/include
CPPFLAGS_common += -Isrc/soc/qualcomm/common/include
################################################################################
# look for QC blobs if QC SoC blobs are only available in upstream else ignore
ifeq ($(CONFIG_QC_BLOBS_UPSTREAM),y)
ifeq ($(CONFIG_USE_QC_BLOBS),y)
# TODO: Upload X1P42100 SoC blobs
X1P42100_BLOB := $(top)/3rdparty/qc_blobs/sc7280
X1P42100_BLOB := $(top)/3rdparty/qc_blobs/x1p42100
ifeq ($(CONFIG_QC_SDI_ENABLE),y)
BL31_MAKEARGS += QTI_SDI_BUILD=1
@ -187,6 +189,7 @@ $(GSI_FW_CBFS)-type := raw
$(GSI_FW_CBFS)-compression := $(CBFS_COMPRESS_FLAG)
cbfs-files-y += $(GSI_FW_CBFS)
endif
endif # ifeq ($(CONFIG_USE_QC_BLOBS),y)
endif
endif # ifeq ($(CONFIG_QC_BLOBS_UPSTREAM),y)
endif # ifeq ($(CONFIG_SOC_QUALCOMM_X1P42100),y)