From 4a0c49e6715296b6c54888b8e02be01dee201330 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 13 Dec 2024 23:23:48 +0530 Subject: [PATCH] soc/intel/pantherlake: Keep image clock configuration enable The ImguClkOutEn parameters are required in pantherlake, therefore, avoid disabling the IMGU CLKOUT FSP UPDs. BUG=b:381044394 TEST=Able to see FSP-M UPDs for google/fatcat where IMGU CLKOUTs are not disabled with this patch. Change-Id: Ieb022e6dc0b64106ff30f56cd17f9f219276785f Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/85588 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) --- src/soc/intel/pantherlake/romstage/fsp_params.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/soc/intel/pantherlake/romstage/fsp_params.c b/src/soc/intel/pantherlake/romstage/fsp_params.c index 83481a01f4..7076aeff13 100644 --- a/src/soc/intel/pantherlake/romstage/fsp_params.c +++ b/src/soc/intel/pantherlake/romstage/fsp_params.c @@ -115,9 +115,6 @@ static void fill_fspm_uart_params(FSP_M_CONFIG *m_cfg, static void fill_fspm_ipu_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_pantherlake_config *config) { - /* Image clock: disable all clocks for bypassing FSP pin mux */ - memset(m_cfg->ImguClkOutEn, 0, sizeof(m_cfg->ImguClkOutEn)); - /* IPU */ m_cfg->SaIpuEnable = is_devfn_enabled(PCI_DEVFN_IPU); }