From 49a547365697d00a305f08a00bb7c116e5a67ccc Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 11 Mar 2025 10:47:50 -0500 Subject: [PATCH] soc/intel/alderlake/acpi: Fix scope of IOM ACPI device Since the IOM region is outside of the PCH MMIO address space, Windows will report a device error for the IOM since the ACPI scope is under PCI0, but the assigned resource range is not inside an address range for any of PCI0's resources. Correct this by setting the scope of the IOM device to just _SB. TEST=build/boot Win11 on google/banshee, verify USB-C ports functional and coolstar's IOM/TCSS drivers loaded without error. Change-Id: I7e61341dd9b7548a079a1ce3b88025f6391f3203 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/86818 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/soc/intel/alderlake/acpi/tcss.asl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/soc/intel/alderlake/acpi/tcss.asl b/src/soc/intel/alderlake/acpi/tcss.asl index 2d09c6438a..8dfa8750c0 100644 --- a/src/soc/intel/alderlake/acpi/tcss.asl +++ b/src/soc/intel/alderlake/acpi/tcss.asl @@ -321,7 +321,7 @@ Scope (_GPE) } } -Scope (\_SB.PCI0) +Scope (\_SB) { Device (IOM) { @@ -334,7 +334,10 @@ Scope (\_SB.PCI0) /* ACPI_STATUS_DEVICE_HIDDEN_ON */ Name (_STA, 0xB) } +} +Scope (\_SB.PCI0) +{ /* * Operation region defined to access the TCSS_DEVEN. Get the MCHBAR in offset * 0x48 in B0:D0:F0. TCSS device enable base address is in offset 0x7090 of MCHBAR.