From 4985079b161f425137ee9e07ff86ddad1d08727f Mon Sep 17 00:00:00 2001
From: Vladimir Serbinenko <phcoder@gmail.com>
Date: Mon, 3 Feb 2025 03:16:25 +0100
Subject: [PATCH] acpi: Zero-out MADT before filling it
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Otherwise flags field is pre-filled with random garbage.

Change-Id: Ie5dc0720183b8ba07561341003f28a86ffce911e
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86246
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
---
 src/acpi/acpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c
index ffd9b7911f..8f5c09fd08 100644
--- a/src/acpi/acpi.c
+++ b/src/acpi/acpi.c
@@ -138,6 +138,8 @@ static void acpi_create_madt(acpi_header_t *header, void *unused)
 	acpi_madt_t *madt = (acpi_madt_t *)header;
 	unsigned long current = (unsigned long)madt + sizeof(acpi_madt_t);
 
+	memset(madt, 0, sizeof(*madt));
+
 	if (acpi_fill_header(header, "APIC", MADT, sizeof(acpi_madt_t)) != CB_SUCCESS)
 		return;