From 463cda84d245084ac39757c42749cc89c15f3fac Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Tue, 1 Jul 2025 09:00:58 +0200 Subject: [PATCH] mb/siemens/mc_rpl: Remove unused Type-C data definition This mainboard is not going to use Type-C subsystem. Therefore, disable and remove the config data for it. Change-Id: I2d9e53bf63b41811040f84cfe9dedf275f1059e4 Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/coreboot/+/88260 Reviewed-by: Mario Scheithauer Reviewed-by: Kilian Krause Tested-by: build bot (Jenkins) --- src/mainboard/siemens/mc_rpl/Kconfig | 1 - src/mainboard/siemens/mc_rpl/devicetree.cb | 10 ------- src/mainboard/siemens/mc_rpl/dsdt.asl | 1 - src/mainboard/siemens/mc_rpl/ramstage.c | 35 ---------------------- 4 files changed, 47 deletions(-) diff --git a/src/mainboard/siemens/mc_rpl/Kconfig b/src/mainboard/siemens/mc_rpl/Kconfig index c08139e619..d775a470f0 100644 --- a/src/mainboard/siemens/mc_rpl/Kconfig +++ b/src/mainboard/siemens/mc_rpl/Kconfig @@ -16,7 +16,6 @@ config BOARD_SIEMENS_BASEBOARD_MC_RPL select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select SOC_INTEL_COMMON_BLOCK_IPU - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SOC_INTEL_CSE_LITE_SKU select USE_SIEMENS_HWILIB diff --git a/src/mainboard/siemens/mc_rpl/devicetree.cb b/src/mainboard/siemens/mc_rpl/devicetree.cb index 9bd0d15cbd..98e2b4d31e 100644 --- a/src/mainboard/siemens/mc_rpl/devicetree.cb +++ b/src/mainboard/siemens/mc_rpl/devicetree.cb @@ -123,9 +123,6 @@ chip soc/intel/alderlake [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, }" - # TCSS USB3 - register "tcss_aux_ori" = "0" - register "s0ix_enable" = "true" register "dptf_enable" = "true" @@ -311,14 +308,7 @@ chip soc/intel/alderlake end device ref pcie4_0 on end device ref pcie4_1 on end - device ref tbt_pcie_rp0 on end - device ref tbt_pcie_rp1 on end - device ref tbt_pcie_rp2 on end - device ref tbt_pcie_rp3 on end device ref crashlog off end - device ref tcss_xhci on end - device ref tcss_dma0 on end - device ref tcss_dma1 on end device ref xhci on chip drivers/usb/acpi register "desc" = ""Root Hub"" diff --git a/src/mainboard/siemens/mc_rpl/dsdt.asl b/src/mainboard/siemens/mc_rpl/dsdt.asl index f379610866..161069c862 100644 --- a/src/mainboard/siemens/mc_rpl/dsdt.asl +++ b/src/mainboard/siemens/mc_rpl/dsdt.asl @@ -21,7 +21,6 @@ DefinitionBlock( Device (\_SB.PCI0) { #include #include - #include } #if CONFIG(EC_GOOGLE_CHROMEEC) diff --git a/src/mainboard/siemens/mc_rpl/ramstage.c b/src/mainboard/siemens/mc_rpl/ramstage.c index fd8e20332b..c1d50f0a00 100644 --- a/src/mainboard/siemens/mc_rpl/ramstage.c +++ b/src/mainboard/siemens/mc_rpl/ramstage.c @@ -11,7 +11,6 @@ #include #include #include -#include "board_id.h" #include const struct cpu_power_limits limits[] = { @@ -63,41 +62,7 @@ void variant_update_power_limits(void) } } -static const struct typec_aux_bias_pads pad_config = { GPP_E23, GPP_E22 }; - -static const struct board_id_iom_port_config { - int board_id; - enum typec_port_index port; -} port_config[] = { - { ADL_P_LP4_1, TYPE_C_PORT_2 }, - { ADL_P_LP4_2, TYPE_C_PORT_2 }, - { ADL_P_DDR4_1, TYPE_C_PORT_2 }, - { ADL_P_DDR4_2, TYPE_C_PORT_2 }, - { ADL_P_LP5_1, TYPE_C_PORT_2 }, - { ADL_P_LP5_2, TYPE_C_PORT_2 }, - { ADL_M_LP4, TYPE_C_PORT_1 }, - { ADL_M_LP5, TYPE_C_PORT_0 }, -}; - -static void variant_update_typec_init_config(void) -{ - /* Skip filling aux bias gpio pads for Windows SKUs */ - if (!(CONFIG(BOARD_INTEL_ADLRVP_P_EXT_EC) || CONFIG(BOARD_INTEL_ADLRVP_RPL_EXT_EC))) - return; - - config_t *config = config_of_soc(); - int board_id = get_board_id(); - for (int i = 0; i < ARRAY_SIZE(port_config); i++) { - if (board_id != port_config[i].board_id) - continue; - - memcpy(&config->typec_aux_bias_pads[port_config[i].port], &pad_config, - sizeof(pad_config)); - } -} - void variant_devtree_update(void) { variant_update_power_limits(); - variant_update_typec_init_config(); }