From 45163509cf63dc4f513c9ee91edf4f5b7a6b46a0 Mon Sep 17 00:00:00 2001 From: Maximilian Brune Date: Tue, 23 Jul 2024 12:37:05 +0200 Subject: [PATCH] util/cbfstool/cbfs-payload-linux.c: Remove TODO LZMA checks at util/cbfstool/lzma/lzma.c:Write() for the output buffer/stream size and does not write beyond it. LZ4 checks at src/commonlib/bsd/lz4.c.inc:LZ4_decompress_generic() for the buffer/stream size and does not write beyond it. Change-Id: I41298b509b3f5e775bb4000c82c539eefa80c885 Signed-off-by: Maximilian Brune Reviewed-on: https://review.coreboot.org/c/coreboot/+/83618 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones --- util/cbfstool/cbfs-payload-linux.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/util/cbfstool/cbfs-payload-linux.c b/util/cbfstool/cbfs-payload-linux.c index 0eb841df82..33f154f326 100644 --- a/util/cbfstool/cbfs-payload-linux.c +++ b/util/cbfstool/cbfs-payload-linux.c @@ -187,11 +187,6 @@ static int bzp_output_segment(struct bzpayload *bzp, struct buffer *b, * add support for more parameters to trampoline: * alt_mem_k, ext_mem_k (not strictly necessary since e820 takes precedence) * framebuffer/console values - * - * larger work: - * is compress() safe to use in a size constrained buffer? ie. do(es) the - * compression algorithm(s) stop once the compression result reaches input - * size (ie. incompressible data)? */ int parse_bzImage_to_payload(const struct buffer *input, struct buffer *output, const char *initrd_name,