From 4499c6d65c6cf246d2cddfc86977fdb1d7dbb2bb Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 29 Jan 2026 16:31:46 -0600 Subject: [PATCH] util/inteltool: Unify LPC/eSPI handling for ADL/RPL Handle ADL-P and ADL-M PCI IDs the same as ADL-N and RPL-P for dumping LPC registers. Add southbridge names/labels for ADL-P and ADL-M. TEST=build and run 'inteltool -l' to dump LPC/eSPI registers on google/taeko (RPL-P), verify output matches LPC decode set in devicetree Change-Id: I84901a8e25eb679acb31be1caa8fffa667454c62 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/91026 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- util/inteltool/inteltool.c | 6 ++++-- util/inteltool/lpc.c | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index bc40e57daa..66d42a903d 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -483,8 +483,10 @@ static const struct { { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C266, "C266" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EHL, "Elkhart Lake" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JSL, "Jasper Lake" }, - { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_N, "Alder Lake-N"}, - { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_RPL_P, "Raptor Lake" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_M, "Alder Lake-M" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_N, "Alder Lake-N" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ADL_P, "Alder Lake-P" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_RPL_P, "Raptor Lake-P" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MTL_P, "Meteor Lake-P"}, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ARL_H, "Arrow Lake-H"}, diff --git a/util/inteltool/lpc.c b/util/inteltool/lpc.c index 711e64b1a2..0d21bedc80 100644 --- a/util/inteltool/lpc.c +++ b/util/inteltool/lpc.c @@ -168,7 +168,10 @@ int print_lpc(struct pci_dev *sb, struct pci_access *pacc) cfg_registers_size = ARRAY_SIZE(sunrise_lpc_cfg_registers); } break; + case PCI_DEVICE_ID_INTEL_ADL_M: case PCI_DEVICE_ID_INTEL_ADL_N: + case PCI_DEVICE_ID_INTEL_ADL_P: + case PCI_DEVICE_ID_INTEL_RPL_P: dev = pci_get_dev(pacc, sb->domain, sb->bus, sb->dev, 0); if (!dev) { printf("LPC/eSPI interface not found.\n");