From 436503fda43f4a8f4eb7d29776fa92c8a2dcd0b4 Mon Sep 17 00:00:00 2001 From: Ariel Otilibili Date: Fri, 27 Dec 2024 00:15:18 +0100 Subject: [PATCH] drivers/uart: Replace 'unsigned long int' by 'unsigned long' As suggested by the linter: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/artifact/lint.txt Change-Id: I1416a2f7d75a888dcaf0775894aced981800866f Signed-off-by: Ariel Otilibili Reviewed-on: https://review.coreboot.org/c/coreboot/+/85784 Tested-by: build bot (Jenkins) Reviewed-by: Maximilian Brune Reviewed-by: Elyes Haouas --- src/drivers/uart/uart8250io.c | 6 +++--- src/drivers/uart/uart8250mem.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index a7fc3466f3..89ec229dfc 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -26,14 +26,14 @@ static int uart8250_can_tx_byte(unsigned int base_port) static void uart8250_tx_byte(unsigned int base_port, unsigned char data) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i-- && !uart8250_can_tx_byte(base_port)); outb(data, base_port + UART8250_TBR); } static void uart8250_tx_flush(unsigned int base_port) { - unsigned long int i = FIFO_TIMEOUT; + unsigned long i = FIFO_TIMEOUT; while (i-- && !(inb(base_port + UART8250_LSR) & UART8250_LSR_TEMT)); } @@ -44,7 +44,7 @@ static int uart8250_can_rx_byte(unsigned int base_port) static unsigned char uart8250_rx_byte(unsigned int base_port) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i && !uart8250_can_rx_byte(base_port)) i--; diff --git a/src/drivers/uart/uart8250mem.c b/src/drivers/uart/uart8250mem.c index 19677a8a6a..fcf031e378 100644 --- a/src/drivers/uart/uart8250mem.c +++ b/src/drivers/uart/uart8250mem.c @@ -46,7 +46,7 @@ static int uart8250_mem_can_tx_byte(void *base) static void uart8250_mem_tx_byte(void *base, unsigned char data) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i-- && !uart8250_mem_can_tx_byte(base)) udelay(1); uart8250_write(base, UART8250_TBR, data); @@ -54,7 +54,7 @@ static void uart8250_mem_tx_byte(void *base, unsigned char data) static void uart8250_mem_tx_flush(void *base) { - unsigned long int i = FIFO_TIMEOUT; + unsigned long i = FIFO_TIMEOUT; while (i-- && !(uart8250_read(base, UART8250_LSR) & UART8250_LSR_TEMT)) udelay(1); } @@ -66,7 +66,7 @@ static int uart8250_mem_can_rx_byte(void *base) static unsigned char uart8250_mem_rx_byte(void *base) { - unsigned long int i = SINGLE_CHAR_TIMEOUT; + unsigned long i = SINGLE_CHAR_TIMEOUT; while (i && !uart8250_mem_can_rx_byte(base)) { udelay(1); i--;