From 4301c50faa4246daa60a72a613a66ab55dd6758a Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Wed, 8 Mar 2017 10:51:52 +0100 Subject: [PATCH] UPSTREAM: cbfstool/ifwitool: Remove unnecessary assignment Fix the warning below. ``` util/cbfstool/ifwitool.c:551:2: warning: Value stored to 'offset' is never read offset = read_member(data, offset, sizeof(h->fit_tool_version), ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` BUG=none BRANCH=none TEST=none Change-Id: Ic214cc66a62c7991c702e5175a298c6fa378ca04 Signed-off-by: Patrick Georgi Original-Commit-Id: deb9b03af9aff54a3dee390cbd5ee63b0b6fcc26 Original-Found-by: scan-build from clang 3.8.1 Original-Change-Id: I6c322a335a371a20561b32e04e7dcc7310dab607 Original-Signed-off-by: Paul Menzel Original-Reviewed-on: https://review.coreboot.org/18667 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Nico Huber Reviewed-on: https://chromium-review.googlesource.com/462964 --- util/cbfstool/ifwitool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/cbfstool/ifwitool.c b/util/cbfstool/ifwitool.c index f6ca2a848e..32d09ca6c8 100644 --- a/util/cbfstool/ifwitool.c +++ b/util/cbfstool/ifwitool.c @@ -548,8 +548,8 @@ static void bpdt_read_header(void *data, struct bpdt_header *h, &h->xor_redundant_block); offset = read_member(data, offset, sizeof(h->ifwi_version), &h->ifwi_version); - offset = read_member(data, offset, sizeof(h->fit_tool_version), - &h->fit_tool_version); + read_member(data, offset, sizeof(h->fit_tool_version), + &h->fit_tool_version); bpdt_validate_header(h, name); bpdt_print_header(h, name);