erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick

Browse source 
Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login
screen, it is because it inserts 12 blank frames if it receives the
unmute in VB-ID.

Always override the mute in VB-ID to avoid Tcon EC detected the
audiomute_flag change.

BUG:b=357764688
BRANCH=firmware-nissa-15217.B
TEST:Verfied on Anraggar and cannot reproduce the issue

Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d
Signed-off-by: Simon Yang <simon1.yang@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84098
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Simon Yang 2024-08-27 11:24:50 +08:00 • committed by Felix Held
commit 425e6bc1a9
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/mainboard/google/brya/variants/anraggar/variant.c
View file

@ -5,6 +5,11 @@
#include <fw_config.h>
#include <sar.h>
#include <soc/gpio_soc_defs.h>
#include <intelblocks/graphics.h>
/* Per-pipe DDI Function Control 2 */
#define TRANS_DDI_FUNC_CTL2_A 0x60404
#define TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS (3 << 6)
const char *get_wifi_sar_cbfs_filename(void)
{
@ -37,3 +42,16 @@ void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
config->typec_aux_bias_pads[1].pad_auxn_dc = GPP_E23;
}
}
void variant_finalize(void)
{
/*
* Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login screen,
* it is because it inserts 12 blank frames if it receives the unmute in VB-ID.
*
* Always override the mute in VB-ID to avoid Tcon EC detected the
* audiomute_flag change.
*/
graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, ~TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS,
TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS);
}