From 42379e7f76079587bfed4a14707a351df0448e49 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 20 Apr 2025 16:02:43 -0500 Subject: [PATCH] sb/intel/lynxpoint: Allow ME enable/disable via option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add an option variable 'me_disable' to control the visibility of the HECI PCI device at runtime. Default to the Kconfig selection if not set. Change-Id: I12c4c9f062cb5904c2f9c05b333bf0ed81aba632 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/87384 Reviewed-by: Angel Pons Reviewed-by: Jérémy Compostella Tested-by: build bot (Jenkins) --- src/southbridge/intel/lynxpoint/me.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/southbridge/intel/lynxpoint/me.c b/src/southbridge/intel/lynxpoint/me.c index b0d98d4c2b..ddeb4b4b50 100644 --- a/src/southbridge/intel/lynxpoint/me.c +++ b/src/southbridge/intel/lynxpoint/me.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include "chip.h" @@ -542,7 +543,7 @@ void intel_me_finalize(struct device *dev) /* Try to send EOP command so ME stops accepting other commands */ mkhi_end_of_post(); - if (!CONFIG(DISABLE_ME_PCI)) + if (!get_uint_option("me_disable", CONFIG(DISABLE_ME_PCI))) return; /* Make sure IO is disabled */ @@ -905,7 +906,7 @@ static void intel_me_init(struct device *dev) static void intel_me_enable(struct device *dev) { /* Avoid talking to the device in S3 path */ - if (acpi_is_wakeup_s3() && CONFIG(DISABLE_ME_PCI)) { + if (acpi_is_wakeup_s3() && get_uint_option("me_disable", CONFIG(DISABLE_ME_PCI))) { dev->enabled = 0; pch_disable_devfn(dev); }