erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

util/chromeos/crosfirmware.sh: Refactor dependency checking

Browse source 
Refactor exit_if_dependencies_are_missing() to check all dependencies
in a single pass using an associative array, collect any missing ones,
and report them all together before exiting. This provides better UX
by showing all missing dependencies at once rather than exiting after
the first one.

This replaces the previous approach that would exit immediately upon
finding the first missing dependency, often causing users to run the
script several times to identify and install all missing dependencies.

Change-Id: Ieb03756b24fd2aa1af2c0ffaed717d06c9e85cbb
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90785
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2026-01-16 17:26:58 -06:00
commit 4222a1ffd6
1 changed files with 26 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

47
util/chromeos/crosfirmware.sh
View file

@ -5,27 +5,34 @@
# On some systems, `parted` and `debugfs` are located in /sbin.
export PATH="$PATH:/sbin"
exit_if_uninstalled() {
local cmd_name="$1"
local deb_pkg_name="$2"
if type "$cmd_name" >/dev/null 2>&1; then
return
fi
printf '`%s` was not found. ' "$cmd_name" >&2
printf 'On Debian-based systems, it can be installed\n' >&2
printf 'by running `apt install %s`.\n' "$deb_pkg_name" >&2
exit 1
}
exit_if_dependencies_are_missing() {
exit_if_uninstalled "uudecode" "sharutils"
exit_if_uninstalled "debugfs" "e2fsprogs"
exit_if_uninstalled "parted" "parted"
exit_if_uninstalled "curl" "curl"
exit_if_uninstalled "unzip" "unzip"
local missing_deps=()
local -A deps_map=(
["uudecode"]="sharutils"
["debugfs"]="e2fsprogs"
["parted"]="parted"
["curl"]="curl"
["unzip"]="unzip"
)
# Check all dependencies at once
for cmd_name in "${!deps_map[@]}"; do
if ! type "$cmd_name" >/dev/null 2>&1; then
missing_deps+=("$cmd_name:${deps_map[$cmd_name]}")
fi
done
# Exit if any dependencies are missing
if [ ${#missing_deps[@]} -gt 0 ]; then
printf 'The following required commands were not found:\n' >&2
for dep_info in "${missing_deps[@]}"; do
cmd_name="${dep_info%%:*}"
deb_pkg_name="${dep_info##*:}"
printf ' - `%s`\n' "$cmd_name" >&2
printf ' On Debian-based systems, install with: `apt install %s`\n' "$deb_pkg_name" >&2
done
exit 1
fi
}
get_inventory() {