From 41e09a5c5961cbc7a1b73f495c5c12560fa8a857 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 12 Jun 2025 13:12:50 -0500 Subject: [PATCH] mb/google/fizz/var/karma: Correct channel count for DMIC This board only has 2 DMIC physically connected, and attempting to record from 4 channels vs 2 results in a large amount of background noise which drowns out the recording. Selecting the 2 channel DMIC shows audio on both channels and no noise. TEST=build/boot fizz/karma, test built-in mic under Windows and Linux. Change-Id: I48162ff25d8c7f413e651c07a7f8e9604bee224c Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/88081 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/mainboard/google/fizz/Kconfig | 2 +- src/mainboard/google/fizz/variants/karma/nhlt.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 635170cc4c..d07ce2ff10 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -95,7 +95,7 @@ config INCLUDE_NHLT_BLOBS config INCLUDE_NHLT_BLOBS_KARMA bool "Include blobs for karma audio." select NHLT_DA7219 - select NHLT_DMIC_4CH + select NHLT_DMIC_2CH select NHLT_MAX98357 config UART_FOR_CONSOLE diff --git a/src/mainboard/google/fizz/variants/karma/nhlt.c b/src/mainboard/google/fizz/variants/karma/nhlt.c index b0f4527ad6..f0ac84168a 100644 --- a/src/mainboard/google/fizz/variants/karma/nhlt.c +++ b/src/mainboard/google/fizz/variants/karma/nhlt.c @@ -7,9 +7,9 @@ void variant_nhlt_init(struct nhlt *nhlt) { - /* 4 Channel DMIC array. */ - if (nhlt_soc_add_dmic_array(nhlt, 4)) - printk(BIOS_ERR, "Couldn't add 4CH DMIC array.\n"); + /* 2 Channel DMIC array. */ + if (nhlt_soc_add_dmic_array(nhlt, 2)) + printk(BIOS_ERR, "Couldn't add 2CH DMIC array.\n"); /* Dialog DA7219 Headset codec. */ if (nhlt_soc_add_da7219(nhlt, AUDIO_LINK_SSP1))