diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 3212ee584a..63d8e6a4d7 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -1,13 +1,13 @@ chip soc/intel/alderlake # FSP UPDs - register "eist_enable" = "true" - register "enable_c6dram" = "1" - register "energy_efficient_turbo" = "true" - register "sagv" = "SaGv_Enabled" + register "eist_enable" = "true" + register "enable_c6dram" = "1" + register "energy_efficient_turbo" = "true" + register "sagv" = "SaGv_Enabled" # Serial I/O register "serial_io_i2c_mode" = "{ - [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C0] = PchSerialIoPci, }" register "common_soc_config" = "{ @@ -17,7 +17,7 @@ chip soc/intel/alderlake }" register "serial_io_uart_mode" = "{ - [PchSerialIoIndexUART0] = PchSerialIoSkipInit, + [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" # Power @@ -26,7 +26,6 @@ chip soc/intel/alderlake register "pch_slp_sus_min_assertion_width" = "SLP_SUS_ASSERTION_1_S" register "pch_slp_a_min_assertion_width" = "SLP_A_ASSERTION_98_MS" - # Device Tree device domain 0 on device ref igpu on chip drivers/gfx/generic @@ -84,68 +83,68 @@ chip soc/intel/alderlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" + register "desc" = ""USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" + register "desc" = ""USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref usb3_port3 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 1)" device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 1)" device ref usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""Right USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Right USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb2_port7 on end end chip drivers/usb/acpi - register "desc" = ""Right USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Right USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb3_port2 on end end chip drivers/usb/acpi - register "desc" = ""Internal Webcam"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""Internal Webcam"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb2_port5 on end end chip drivers/usb/acpi - register "desc" = ""Fingerprint Reader"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 4)" + register "desc" = ""Fingerprint Reader"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 4)" device ref usb2_port6 on end end chip drivers/usb/acpi - register "desc" = ""USB 2.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 5)" + register "desc" = ""USB 2.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 5)" device ref usb2_port4 on end end chip drivers/usb/acpi - register "desc" = ""Internal Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 6)" - register "is_intel_bluetooth" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" + register "desc" = ""Internal Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 6)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device ref usb2_port10 on end end end @@ -187,9 +186,9 @@ chip soc/intel/alderlake register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" - register "skip_on_off_support" = "1" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -207,15 +206,16 @@ chip soc/intel/alderlake "SlotLengthLong" "M.2/M 2280" "SlotDataBusWidth4X" + chip soc/intel/common/block/pcie/rtd3 register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0)" register "srcclk_pin" = "1" - register "is_storage" = "1" - register "add_acpi_dma_property" = "1" - register "skip_on_off_support" = "1" + register "is_storage" = "true" + register "add_acpi_dma_property" = "true" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -267,8 +267,8 @@ chip soc/intel/alderlake subsystemid 0x1e50 0x7007 register "pch_hda_sdi_enable[0]" = "true" register "pch_hda_dsp_enable" = "true" - register "pch_hda_audio_link_hda_enable" = "1" - register "pch_hda_idisp_codec_enable" = "1" + register "pch_hda_audio_link_hda_enable" = "true" + register "pch_hda_idisp_codec_enable" = "true" register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" end diff --git a/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb index 11b969fd26..dbb7dca439 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb @@ -24,7 +24,6 @@ chip soc/intel/meteorlake register "pch_slp_sus_min_assertion_width" = "SLP_SUS_ASSERTION_1_S" register "pch_slp_a_min_assertion_width" = "SLP_A_ASSERTION_98_MS" - # Device Tree device domain 0 on device ref igpu on chip drivers/gfx/generic @@ -107,62 +106,62 @@ chip soc/intel/meteorlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""Back USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" + register "desc" = ""Back USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""Front USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "desc" = ""Front USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 1))" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 1))" device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb2_port2 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""Right Rear USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""Right Rear USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb2_port7 on end end chip drivers/usb/acpi - register "desc" = ""Right Rear USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""Right Rear USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb3_port2 on end end chip drivers/usb/acpi - register "desc" = ""Internal Webcam"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 4)" + register "desc" = ""Internal Webcam"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 4)" device ref usb2_port5 on end end chip drivers/usb/acpi - register "desc" = ""USB 2.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 5)" + register "desc" = ""USB 2.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 5)" device ref usb2_port8 on end end chip drivers/usb/acpi - register "desc" = ""Internal Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - register "is_intel_bluetooth" = "true" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B18)" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B18)" - register "group" = "ACPI_PLD_GROUP(0, 6)" + register "desc" = ""Internal Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "is_intel_bluetooth" = "true" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B18)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B18)" + register "group" = "ACPI_PLD_GROUP(0, 6)" device ref usb2_port10 on end end end @@ -188,6 +187,7 @@ chip soc/intel/meteorlake .pcie_rp_aspm = ASPM_L0S_L1, .PcieRpL1Substates = L1_SS_L1_2, }" + smbios_slot_desc "SlotTypePciExpressGen3X1" "SlotLengthShort" "M.2/M 2230" @@ -211,8 +211,8 @@ chip soc/intel/meteorlake .flags = PCIE_RP_LTR | PCIE_RP_AER, .pcie_rp_aspm = ASPM_L0S_L1, .PcieRpL1Substates = L1_SS_L1_2, - }" + smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthLong" "M.2/M 2280" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 7637af896b..8a7652f278 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -28,7 +28,6 @@ chip soc/intel/alderlake register "pch_slp_sus_min_assertion_width" = "SLP_SUS_ASSERTION_1_S" register "pch_slp_a_min_assertion_width" = "SLP_A_ASSERTION_98_MS" - # Device Tree device domain 0 on device ref igpu on chip drivers/gfx/generic @@ -70,15 +69,16 @@ chip soc/intel/alderlake "SlotLengthLong" "M.2/M 2280" "SlotDataBusWidth4X" + chip soc/intel/common/block/pcie/rtd3 register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D14)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F20)" register "srcclk_pin" = "4" - register "is_storage" = "1" - register "add_acpi_dma_property" = "1" - register "skip_on_off_support" = "1" + register "is_storage" = "true" + register "add_acpi_dma_property" = "true" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -132,66 +132,65 @@ chip soc/intel/alderlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" + register "desc" = ""USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 1)" device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 1)" device ref usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""Right USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Right USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb2_port7 on end end chip drivers/usb/acpi - register "desc" = ""Right USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Right USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb3_port2 on end end chip drivers/usb/acpi - register "desc" = ""Internal Webcam"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""Internal Webcam"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb2_port5 on end end chip drivers/usb/acpi - register "desc" = ""Fingerprint Reader"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 4)" + register "desc" = ""Fingerprint Reader"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 4)" device ref usb2_port6 on end end chip drivers/usb/acpi - register "desc" = ""USB 2.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 5)" + register "desc" = ""USB 2.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 5)" device ref usb2_port4 on end end chip drivers/usb/acpi - register "desc" = ""Internal Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 6)" - register "is_intel_bluetooth" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" + register "desc" = ""Internal Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 6)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device ref usb2_port10 on end end end end - end device ref i2c0 on chip drivers/i2c/hid @@ -215,6 +214,7 @@ chip soc/intel/alderlake .pcie_rp_aspm = ASPM_L0S_L1, .PcieRpL1Substates = L1_SS_L1_2, }" + smbios_slot_desc "SlotTypePciExpressGen3X1" "SlotLengthShort" "M.2/M 2230" @@ -223,10 +223,10 @@ chip soc/intel/alderlake register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" - register "skip_on_off_support" = "1" register "add_acpi_dma_property" = "true" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -278,8 +278,8 @@ chip soc/intel/alderlake subsystemid 0x1e50 0x7007 register "pch_hda_sdi_enable[0]" = "true" register "pch_hda_dsp_enable" = "true" - register "pch_hda_audio_link_hda_enable" = "1" - register "pch_hda_idisp_codec_enable" = "1" + register "pch_hda_audio_link_hda_enable" = "true" + register "pch_hda_idisp_codec_enable" = "true" register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" end diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index 9f660d5cb2..3808aca17b 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -1,26 +1,15 @@ chip soc/intel/tigerlake # FSP UPDs - register "eist_enable" = "true" - register "enable_c6dram" = "1" - register "CnviBtCore" = "true" - register "CnviBtAudioOffload" = "1" - register "SaGv" = "SaGv_Enabled" - - # Graphics - # Not used but timings left for reference - # register "panel_cfg" = "{ - # .up_delay_ms = 2000, // T3 - # .backlight_on_delay_ms = 0, // T7 - # .backlight_off_delay_ms = 2000, // T9 - # .down_delay_ms = 500, // T10 - # .cycle_delay_ms = 500, // T12 - # .backlight_pwm_hz = 200, // PWM - # }" + register "eist_enable" = "true" + register "enable_c6dram" = "true" + register "CnviBtCore" = "true" + register "CnviBtAudioOffload" = "true" + register "SaGv" = "SaGv_Enabled" # Serial I/O register "SerialIoI2cMode" = "{ - [PchSerialIoIndexI2C0] = PchSerialIoPci, - [PchSerialIoIndexI2C4] = PchSerialIoSkipInit, + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C4] = PchSerialIoSkipInit, }" register "common_soc_config" = "{ @@ -30,14 +19,14 @@ chip soc/intel/tigerlake }" register "SerialIoUartMode" = "{ - [PchSerialIoIndexUART2] = PchSerialIoSkipInit, + [PchSerialIoIndexUART2] = PchSerialIoSkipInit, }" # Power - register "PchPmSlpS3MinAssert" = "2" # 1ms - register "PchPmSlpS4MinAssert" = "3" # 3s - register "PchPmSlpSusMinAssert" = "3" # 1s - register "PchPmSlpAMinAssert" = "3" # 98ms + register "PchPmSlpS3MinAssert" = "2" # 1ms + register "PchPmSlpS4MinAssert" = "3" # 3s + register "PchPmSlpSusMinAssert" = "3" # 1s + register "PchPmSlpAMinAssert" = "3" # 98ms # Enable the correct decode ranges on the LPC bus. register "lpc_ioe" = "LPC_IOE_EC_4E_4F | @@ -109,54 +98,54 @@ chip soc/intel/tigerlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(0, 0)" + register "desc" = ""USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "group" = "ACPI_PLD_GROUP(0, 0)" device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 1)" device ref usb2_port2 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 1)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 1)" device ref usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""Right USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Right USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""Right USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Right USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb3_port2 on end end chip drivers/usb/acpi - register "desc" = ""Internal Webcam"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""Internal Webcam"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb2_port4 on end end chip drivers/usb/acpi - register "desc" = ""USB 2.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 4)" + register "desc" = ""USB 2.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 4)" device ref usb2_port6 on end end chip drivers/usb/acpi - register "desc" = ""Internal Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 5)" - register "is_intel_bluetooth" = "1" + register "desc" = ""Internal Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 5)" + register "is_intel_bluetooth" = "1" register "cnvi_bt_audio_offload" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(CNV_BTEN)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(CNV_BTEN)" device ref usb2_port10 on end end end @@ -217,6 +206,7 @@ chip soc/intel/tigerlake register "gen1_dec" = "0x00040069" register "gen2_dec" = "0x00fc0201" register "gen3_dec" = "0x000c0081" + chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index a9221cae48..c82bc9aaf0 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -76,11 +76,11 @@ chip soc/intel/alderlake register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D14)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F20)" register "srcclk_pin" = "4" - register "is_storage" = "1" - register "add_acpi_dma_property" = "1" - register "skip_on_off_support" = "1" + register "is_storage" = "true" + register "add_acpi_dma_property" = "true" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -90,15 +90,15 @@ chip soc/intel/alderlake chip drivers/usb/acpi device ref tcss_root_hub on chip drivers/usb/acpi - register "desc" = ""Left Back USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "desc" = ""Left Back USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref tcss_usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""Left Front USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "desc" = ""Left Front USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 1))" device ref tcss_usb3_port2 on end @@ -145,55 +145,55 @@ chip soc/intel/alderlake chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""Left Back USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" + register "desc" = ""Left Back USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "use_custom_pld" = "true" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 0))" device ref usb2_port1 on end end chip drivers/usb/acpi - register "desc" = ""Left Front USB Type-C"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" + register "desc" = ""Left Front USB Type-C"" + register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 1))" + register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, CENTER, ACPI_PLD_GROUP(0, 1))" device ref usb2_port2 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb2_port3 on end end chip drivers/usb/acpi - register "desc" = ""Left USB Type-A"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(0, 2)" + register "desc" = ""Left USB Type-A"" + register "type" = "UPC_TYPE_USB3_A" + register "group" = "ACPI_PLD_GROUP(0, 2)" device ref usb3_port1 on end end chip drivers/usb/acpi - register "desc" = ""USB 3.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""USB 3.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb2_port6 on end end chip drivers/usb/acpi - register "desc" = ""USB 3.0 Hub"" - register "type" = "UPC_TYPE_HUB" - register "group" = "ACPI_PLD_GROUP(0, 3)" + register "desc" = ""USB 3.0 Hub"" + register "type" = "UPC_TYPE_HUB" + register "group" = "ACPI_PLD_GROUP(0, 3)" device ref usb3_port2 on end end chip drivers/usb/acpi - register "desc" = ""Internal Webcam"" - register "group" = "ACPI_PLD_GROUP(0, 4)" + register "desc" = ""Internal Webcam"" + register "group" = "ACPI_PLD_GROUP(0, 4)" device ref usb2_port5 on end end chip drivers/usb/acpi - register "desc" = ""Internal Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - register "group" = "ACPI_PLD_GROUP(0, 5)" - register "is_intel_bluetooth" = "1" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" + register "desc" = ""Internal Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "group" = "ACPI_PLD_GROUP(0, 5)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device ref usb2_port10 on end end end @@ -201,15 +201,15 @@ chip soc/intel/alderlake end device ref i2c0 on chip drivers/i2c/hid - register "generic.hid" = ""STAR0001"" - register "generic.desc" = ""Touchpad"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D11_IRQ)" - register "hid_desc_reg_offset" = "0x20" + register "generic.hid" = ""STAR0001"" + register "generic.desc" = ""Touchpad"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D11_IRQ)" + register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end end device ref shared_sram on end - device ref pcie_rp5 on # WiFi + device ref pcie_rp5 on # WiFi chip drivers/wifi/generic register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end @@ -230,9 +230,9 @@ chip soc/intel/alderlake register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" - register "skip_on_off_support" = "1" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -256,11 +256,11 @@ chip soc/intel/alderlake register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0)" register "srcclk_pin" = "1" - register "is_storage" = "1" - register "add_acpi_dma_property" = "1" - register "skip_on_off_support" = "1" + register "is_storage" = "true" + register "add_acpi_dma_property" = "true" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end @@ -315,10 +315,10 @@ chip soc/intel/alderlake end device ref hda on subsystemid 0x10ec 0x1200 - register "pch_hda_sdi_enable[0]" = "1" + register "pch_hda_sdi_enable[0]" = "true" register "pch_hda_dsp_enable" = "true" - register "pch_hda_audio_link_hda_enable" = "1" - register "pch_hda_idisp_codec_enable" = "1" + register "pch_hda_audio_link_hda_enable" = "true" + register "pch_hda_idisp_codec_enable" = "true" register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" end diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index d9996caf29..bb9ab534b2 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -60,30 +60,30 @@ chip soc/intel/alderlake device generic 0 on end end - register "ddi_portA_config" = "1" + register "ddi_portA_config" = "1" register "ddi_ports_config" = "{ - [DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, }" end device ref gna on end device ref xhci on - # Bottom USB 3.0 Type-C 3289 mil - register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)" - register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" + # Bottom USB 3.0 Type-C 3289 mil + register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)" + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" - # Top USB 3.0 Type-C 4237 mil - register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)" - register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" + # Top USB 3.0 Type-C 4237 mil + register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)" + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" - # Detachable Keyboard + SD Card Reader 6418 mil - register "usb2_ports[2]" = "USB2_PORT_SHORT(OC_SKIP)" + # Detachable Keyboard + SD Card Reader 6418 mil + register "usb2_ports[2]" = "USB2_PORT_SHORT(OC_SKIP)" - # Camera + Webcam 3249 mil - register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_SHORT(OC_SKIP)" + # Camera + Webcam 3249 mil + register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_SHORT(OC_SKIP)" - # Internal Bluetooth 1874 mil - register "usb2_ports[9]" = "USB2_PORT_SHORT(OC_SKIP)" + # Internal Bluetooth 1874 mil + register "usb2_ports[9]" = "USB2_PORT_SHORT(OC_SKIP)" chip drivers/usb/acpi device ref xhci_root_hub on @@ -187,23 +187,24 @@ chip soc/intel/alderlake "SlotLengthLong" "M.2/M 2242" "SlotDataBusWidth4X" + chip soc/intel/common/block/pcie/rtd3 register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0)" register "srcclk_pin" = "0" - register "is_storage" = "1" - register "add_acpi_dma_property" = "1" - register "skip_on_off_support" = "1" + register "is_storage" = "true" + register "add_acpi_dma_property" = "true" + register "skip_on_off_support" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" - register "use_rp_mutex" = "1" + register "use_rp_mutex" = "true" device generic 0 on end end end device ref uart0 on end device ref pch_espi on - register "gen1_dec" = "0x00040069" - register "gen2_dec" = "0x00fc0201" - register "gen3_dec" = "0x000c0081" + register "gen1_dec" = "0x00040069" + register "gen2_dec" = "0x00fc0201" + register "gen3_dec" = "0x000c0081" chip ec/starlabs/merlin # Port pair 4Eh/4Fh @@ -212,9 +213,9 @@ chip soc/intel/alderlake device pnp 4e.04 off end # System Wake-Up device pnp 4e.05 off end # PS/2 Mouse device pnp 4e.06 on # PS/2 Keyboard - io 0x60 = 0x0060 - io 0x62 = 0x0064 - irq 0x70 = 1 + io 0x60 = 0x0060 + io 0x62 = 0x0064 + irq 0x70 = 1 end device pnp 4e.0a off end # Consumer IR device pnp 4e.0f off end # Shared Memory/Flash Interface @@ -248,8 +249,8 @@ chip soc/intel/alderlake subsystemid 0x1e50 0x7038 register "pch_hda_sdi_enable[0]" = "true" register "pch_hda_dsp_enable" = "true" - register "pch_hda_audio_link_hda_enable" = "1" - register "pch_hda_idisp_codec_enable" = "1" + register "pch_hda_audio_link_hda_enable" = "true" + register "pch_hda_idisp_codec_enable" = "true" register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ" register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T" end