erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/alderlake: Add Vccin Aux Imon Iccmax setting

Browse source 
According to RDC#646929 Power Map, there are two expected values of
VccInAuxImonIccImax and the value has to align with HW design.

But in current code, vccin_aux_imon_iccmax is hard code to 27000 (27A),
hence, provide a config for projects modification.

BUG=b:330117043
BRANCH=firmware-nissa-15217.B
TEST=Modify the register and add a printk to output a debug message
     to observe whether the value is changing as expected.

Change-Id: I0651f0eb8a5c32b27c524e43bbf6f2a184b95657
Signed-off-by: Simon Yang <simon1.yang@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82682
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Derek Huang <derekhuang@google.com>
This commit is contained in:
Simon Yang 2024-05-28 17:41:49 +08:00 • committed by Felix Held
commit 40867e7b47
2 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/soc/intel/alderlake/chip.h
View file

@ -777,6 +777,16 @@ struct soc_intel_alderlake_config {
* Set this to 0 in order to disable hwp scalability tracking.
*/
bool enable_hwp_scalability_tracking;
/*
* (ADL-N/TWL only) Vccin Aux Imon Iccmax
* Defaults to 27000 (27A), the value has to align with HW design.
* Recommended value: 25000 (PD_TIER_PREMIUM) or 27000 (PD_TIER_VOLUME)
*/
enum {
PD_TIER_PREMIUM = 25000,
PD_TIER_VOLUME = 27000
} vccin_aux_imon_iccmax;
};
typedef struct soc_intel_alderlake_config config_t;

8
src/soc/intel/alderlake/fsp_params.c
View file

@ -560,7 +560,7 @@ static void configure_cpu_rp_power_management(FSP_S_CONFIG *s_cfg,
/* This function returns the VccIn Aux Imon IccMax values for ADL and RPL
SKU's */
static uint16_t get_vccin_aux_imon_iccmax(void)
static uint16_t get_vccin_aux_imon_iccmax(const struct soc_intel_alderlake_config *config)
{
struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
uint16_t mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff;
@ -596,7 +596,8 @@ static uint16_t get_vccin_aux_imon_iccmax(void)
case PCI_DID_INTEL_ADL_N_ID_3:
case PCI_DID_INTEL_ADL_N_ID_4:
case PCI_DID_INTEL_ADL_N_ID_5:
return ICC_MAX_ID_ADL_N_MA;
return config->vccin_aux_imon_iccmax
? config->vccin_aux_imon_iccmax : ICC_MAX_ID_ADL_N_MA;
case PCI_DID_INTEL_ADL_S_ID_1:
case PCI_DID_INTEL_ADL_S_ID_3:
case PCI_DID_INTEL_ADL_S_ID_8:
@ -1063,7 +1064,8 @@ static void fill_fsps_misc_power_params(FSP_S_CONFIG *s_cfg,
s_cfg->EnergyEfficientTurbo = 0;
/* VccIn Aux Imon IccMax. Values are in 1/4 Amp increments and range is 0-512. */
s_cfg->VccInAuxImonIccImax = get_vccin_aux_imon_iccmax() * 4 / MILLIAMPS_TO_AMPS;
s_cfg->VccInAuxImonIccImax =
get_vccin_aux_imon_iccmax(config) * 4 / MILLIAMPS_TO_AMPS;
/* VrConfig Settings for IA and GT domains */
for (size_t i = 0; i < ARRAY_SIZE(config->domain_vr_config); i++)