From 3cff5b912d5641acd8e5209839fff874a50a8172 Mon Sep 17 00:00:00 2001 From: Carl-Daniel Hailfinger Date: Thu, 14 Aug 2008 01:40:31 +0000 Subject: [PATCH] The device code had several unclear messages, leading to confusion when analyzing the logs. Improve readability. This code may be obsolete, but that's not entriely sure yet. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Carl-Daniel Hailfinger git-svn-id: svn://coreboot.org/repository/coreboot-v3@759 f3766cd6-281f-0410-b1cd-43a5c92072e9 --- device/hypertransport.c | 5 +++-- device/pci_device.c | 7 ++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/device/hypertransport.c b/device/hypertransport.c index 6f5e49b5de..d6877f9fbb 100644 --- a/device/hypertransport.c +++ b/device/hypertransport.c @@ -580,10 +580,11 @@ unsigned int hypertransport_scan_chain(struct bus *bus, unsigned int min_devfn, */ if (old_devices) { struct device *left; + printk(BIOS_INFO, "HT: Left over static devices:\n"); for (left = old_devices; left; left = left->sibling) { - printk(BIOS_DEBUG, "%s\n", dev_path(left)); + printk(BIOS_INFO, "%s\n", dev_path(left)); } - printk(BIOS_ERR, "HT: Left over static devices.\n"); + printk(BIOS_INFO, "HT: End of leftover list.\n"); /* Put back the left over static device, and let * pci_scan_bus() disable it. */ diff --git a/device/pci_device.c b/device/pci_device.c index 1ed3115b84..06add5bdcb 100644 --- a/device/pci_device.c +++ b/device/pci_device.c @@ -883,7 +883,7 @@ static struct device *pci_scan_get_dev(struct device **list, unsigned int devfn) dev = 0; printk(BIOS_SPEW, "%s: list is %p, *list is %p\n", __func__, list, *list); - for (/* */; *list; list = &(*list)->sibling) { + for (; *list; list = &(*list)->sibling) { printk(BIOS_SPEW, "%s: check dev %s \n", __func__, (*list)->dtsname); if ((*list)->path.type != DEVICE_PATH_PCI) { @@ -1122,10 +1122,11 @@ unsigned int pci_scan_bus(struct bus *bus, unsigned int min_devfn, */ if (old_devices) { struct device *left; + printk(BIOS_INFO, "PCI: Left over static devices:\n"); for (left = old_devices; left; left = left->sibling) { - printk(BIOS_SPEW, "%s\n", left->dtsname); + printk(BIOS_INFO, "%s\n", left->dtsname); } - banner(BIOS_SPEW, "PCI: Left over static devices.\n"); + printk(BIOS_INFO, "PCI: End of leftover list.\n"); } /* For all children that implement scan_bus() (i.e. bridges)