From 3cf74e8fe44275330a492a3bf33d86fd1c5ca8d5 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Tue, 21 May 2013 07:49:11 -0700 Subject: [PATCH] ec: Remove hardcoded GPI offset in EC SCI With LynxPoint-LP the SCI GPE is no longer a GPIO that is offset by 16. Remove the Add and fix up the link definition so it is still accurate. BUG=chrome-os-partner:19035 BRANCH=none TEST=manual: ensure SCI is working on slippy 1) Enable ACPI_DEBUG and ACPI_EC_DEBUGFS in kernel config 2) cat /sys/kernel/debug/ec/ec0/io > /dev/null 3) cat /sys/firmware/acpi/interrupts/gpe24 512 Change-Id: I5c97a8397cdee8f081d690d930da2df61b4695f9 Signed-off-by: Duncan Laurie Reviewed-on: https://gerrit.chromium.org/gerrit/56027 Reviewed-by: Aaron Durbin --- src/ec/google/chromeec/acpi/ec.asl | 2 +- src/mainboard/google/link/ec.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 2fb8e7961c..cb196a7065 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -27,7 +27,7 @@ Device (EC0) { Name (_HID, EISAID ("PNP0C09")) Name (_UID, 1) - Name (_GPE, Add(EC_SCI_GPI, 16)) + Name (_GPE, EC_SCI_GPI) Name (TOFS, EC_TEMP_SENSOR_OFFSET) Name (TNOP, 0xFD) // Thermal sensor has no power Name (TBAD, 0xFE) // Thermal sensor bad reading diff --git a/src/mainboard/google/link/ec.h b/src/mainboard/google/link/ec.h index 6133f97984..0044347aa3 100644 --- a/src/mainboard/google/link/ec.h +++ b/src/mainboard/google/link/ec.h @@ -22,7 +22,7 @@ #include -#define EC_SCI_GPI 7 /* GPIO7 is EC_SCI# */ +#define EC_SCI_GPI 23 /* GPIO7/GPE23 is EC_SCI# */ #define EC_SMI_GPI 8 /* GPIO8 is EC_SMI# */ #define LINK_EC_SCI_EVENTS \