erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tpm2: clean up tpm_marshal_command()

Browse source 
The function is reusing some variables which confuses the reader as
the variable names do not match their second function.

This patch edits the code for readability without changing
functionality.

BRANCH=None
BUG=chrome-os-partner:50465
TEST=with the rest of the patches applied Kevin still boots into
     chrome OS.

Change-Id: I95a07945d9d2b00a69d514014f848802b82dd90f
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/358915
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Vadim Bendebury 2016-07-07 14:27:41 -07:00 • committed by chrome-bot
commit 3cf02c365d
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/lib/tpm2_marshaling.c
View file

@ -357,18 +357,22 @@ int tpm_marshal_command(TPM_CC command, void *tpm_command_body,
}
if (body_size > 0) {
size_t marshaled_size;
size_t header_room = sizeof(struct tpm_header);
/* See how much room was taken by marshaling. */
body_size = max_body_size - body_size;
marshaled_size = max_body_size - body_size;
body_size += sizeof(struct tpm_header);
/* Total size includes the header size. */
marshaled_size += sizeof(struct tpm_header);
marshal_u16(&buffer, tpm_tag, &max_body_size);
marshal_u32(&buffer, body_size, &max_body_size);
marshal_u32(&buffer, command, &max_body_size);
marshal_u16(&buffer, tpm_tag, &header_room);
marshal_u32(&buffer, marshaled_size, &header_room);
marshal_u32(&buffer, command, &header_room);
return marshaled_size;
}
return body_size;
return -1;
}
static void unmarshal_get_capability(void **buffer, int *size,